chrome/browser/gtk/location_bar_view_gtk.cc - Issue 1001002: Initial support for inspecting extension popups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/gtk/location_bar_view_gtk.cc

Issue 1001002: Initial support for inspecting extension popups. (Closed)

Patch Set: pre submit Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/gtk/location_bar_view_gtk.cc

diff --git a/chrome/browser/gtk/location_bar_view_gtk.cc b/chrome/browser/gtk/location_bar_view_gtk.cc

index 1d8c7869eaeaa1b31d77a58326e1430bd99d540c..815bb2f4a08f8a5a4e20eff68426c882f8cc14c1 100644

--- a/chrome/browser/gtk/location_bar_view_gtk.cc

+++ b/chrome/browser/gtk/location_bar_view_gtk.cc

@@ -1217,8 +1217,10 @@ gboolean LocationBarViewGtk::PageActionViewGtk::OnButtonPressed(

Extension* extension = profile_->GetExtensionsService()->GetExtensionById(

page_action()->extension_id(), false);

+ // TODO(rafaelw): support inspecting popups.

if (!context_menu_model_.get())

- context_menu_model_.reset(new ExtensionActionContextMenuModel(extension));

+ context_menu_model_.reset(new ExtensionActionContextMenuModel(extension,

+ page_action_, profile_->GetPrefs(), NULL));

context_menu_.reset(

new MenuGtk(NULL, context_menu_model_.get()));