Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1886)

Unified Diff: chrome/browser/extensions/extension_action_context_menu_model.h

Issue 1001002: Initial support for inspecting extension popups. (Closed)
Patch Set: pre submit Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_action_context_menu_model.h
diff --git a/chrome/browser/extensions/extension_action_context_menu_model.h b/chrome/browser/extensions/extension_action_context_menu_model.h
index 1a8e6641f61b75981d1456185496d87b1cf2c7b6..a35d2695a4784b4f2eec692b515fd4cfb306e87a 100644
--- a/chrome/browser/extensions/extension_action_context_menu_model.h
+++ b/chrome/browser/extensions/extension_action_context_menu_model.h
@@ -9,6 +9,8 @@
#include "chrome/browser/extensions/extension_install_ui.h"
class Extension;
+class ExtensionAction;
+class PrefService;
// The menu model for the context menu for extension action icons (browser and
// page actions).
@@ -17,7 +19,25 @@ class ExtensionActionContextMenuModel
public menus::SimpleMenuModel::Delegate,
public ExtensionInstallUI::Delegate {
public:
- explicit ExtensionActionContextMenuModel(Extension* extension);
+ // Delegate to handle menu commands.
+ class MenuDelegate {
+ public:
+ // Called when the user selects the menu item which requests that the
+ // popup be shown and inspected.
+ virtual void ShowPopupForDevToolsWindow(Extension* extension,
+ ExtensionAction* extension_action) {
+ }
+ };
+
+ // |extension_action|, |prefs|, & |delegate| call all be NULL. If valid
+ // values are provided for all three, and prefs::kExtensionsUIDeveloperMode
+ // is enabled in the PrefService, a menu item will be shown for "Inspect
+ // Popup" which, when selected, will cause ShowPopupForDevToolsWindow() to be
+ // called on |delegate|.
+ ExtensionActionContextMenuModel(Extension* extension,
+ ExtensionAction* extension_action,
+ PrefService* prefs,
+ MenuDelegate* delegate);
~ExtensionActionContextMenuModel();
// SimpleMenuModel behavior overrides.
@@ -35,6 +55,12 @@ class ExtensionActionContextMenuModel
// The extension we are displaying the context menu for.
Extension* extension_;
+ // The extension action we are displaying the context menu for.
+ ExtensionAction* extension_action_;
+
+ // The delegate which handles the 'inspect popup' menu command.
+ MenuDelegate* delegate_;
+
DISALLOW_COPY_AND_ASSIGN(ExtensionActionContextMenuModel);
};
« no previous file with comments | « chrome/browser/debugger/devtools_manager.cc ('k') | chrome/browser/extensions/extension_action_context_menu_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698