Cleanup and simplify HostConfig and JsonHostConfig.

Cleanup and simplify HostConfig and JsonHostConfig.

These classes were previously overdesigned. Simplifying them.
 - Config doesn't need to be ref-counted.
 - Save() is synchronous now.
 - Config is NonThreadSafe now.

BUG=120950
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131288

[Lambros, 2012-04-06 22:26:45]

http://codereview.chromium.org/10007048/diff/1/remoting/host/host_config.h
File remoting/host/host_config.h (right):

http://codereview.chromium.org/10007048/diff/1/remoting/host/host_config.h#ne...
remoting/host/host_config.h:61: // Save's changes.
nit: "Save" or "Saves", no apostrophe.

http://codereview.chromium.org/10007048/diff/1/remoting/host/json_host_config.cc
File remoting/host/json_host_config.cc (right):

http://codereview.chromium.org/10007048/diff/1/remoting/host/json_host_config...
remoting/host/json_host_config.cc:50: file_content.size());
WriteFile returns int: number of bytes written, or -1 on error.  Simple cast to
bool is not correct. I think, for our purposes, it is sufficient to treat
partial write as error.

http://codereview.chromium.org/10007048/diff/1/remoting/host/json_host_config.h
File remoting/host/json_host_config.h (right):

http://codereview.chromium.org/10007048/diff/1/remoting/host/json_host_config...
remoting/host/json_host_config.h:11: #include "base/memory/scoped_ptr.h"
nit: Move scoped_ptr.h from here into .cc file.

[Sergey Ulanov, 2012-04-06 22:32:53]

http://codereview.chromium.org/10007048/diff/1/remoting/host/host_config.h
File remoting/host/host_config.h (right):

http://codereview.chromium.org/10007048/diff/1/remoting/host/host_config.h#ne...
remoting/host/host_config.h:61: // Save's changes.
On 2012/04/06 22:26:46, Lambros wrote:
> nit: "Save" or "Saves", no apostrophe.

Done.

http://codereview.chromium.org/10007048/diff/1/remoting/host/json_host_config.cc
File remoting/host/json_host_config.cc (right):

http://codereview.chromium.org/10007048/diff/1/remoting/host/json_host_config...
remoting/host/json_host_config.cc:50: file_content.size());
On 2012/04/06 22:26:46, Lambros wrote:
> WriteFile returns int: number of bytes written, or -1 on error.  Simple cast
to
> bool is not correct. I think, for our purposes, it is sufficient to treat
> partial write as error.

Done.

http://codereview.chromium.org/10007048/diff/1/remoting/host/json_host_config.h
File remoting/host/json_host_config.h (right):

http://codereview.chromium.org/10007048/diff/1/remoting/host/json_host_config...
remoting/host/json_host_config.h:11: #include "base/memory/scoped_ptr.h"
On 2012/04/06 22:26:46, Lambros wrote:
> nit: Move scoped_ptr.h from here into .cc file.

Done.

[Lambros, 2012-04-06 22:56:35]

lgtm

[commit-bot: I haz the power, 2012-04-06 23:02:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10007048/5002

[commit-bot: I haz the power, 2012-04-06 23:35:38]

Try job failure for 10007048-5002 (retry) on linux_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-04-07 00:29:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10007048/7004

[commit-bot: I haz the power, 2012-04-07 01:22:02]

Try job failure for 10007048-7004 (retry) on mac_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-04-07 01:56:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10007048/13007

[commit-bot: I haz the power, 2012-04-07 02:48:00]

Try job failure for 10007048-13007 (retry) on mac_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-04-07 05:14:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10007048/12008

[commit-bot: I haz the power, 2012-04-07 06:05:35]

Try job failure for 10007048-12008 (retry) on mac_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-04-07 17:32:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10007048/8008

[commit-bot: I haz the power, 2012-04-07 19:20:09]

Change committed as 131288