Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Unified Diff: remoting/host/in_memory_host_config.h

Issue 10007048: Cleanup and simplify HostConfig and JsonHostConfig. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/host_key_pair_unittest.cc ('k') | remoting/host/in_memory_host_config.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/in_memory_host_config.h
diff --git a/remoting/host/in_memory_host_config.h b/remoting/host/in_memory_host_config.h
index 4043e83ba5103e7ba01aa4461797b27f4ad2447c..a24b8ca8fc7e38ffe90ce4f15986842bb3e735c5 100644
--- a/remoting/host/in_memory_host_config.h
+++ b/remoting/host/in_memory_host_config.h
@@ -7,37 +7,36 @@
#include <string>
-#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
-#include "base/synchronization/lock.h"
+#include "base/threading/non_thread_safe.h"
#include "remoting/host/host_config.h"
namespace base {
class DictionaryValue;
-}
+} // namespace base
namespace remoting {
// In-memory host config. Used by unittests.
-class InMemoryHostConfig : public MutableHostConfig {
+class InMemoryHostConfig : public MutableHostConfig,
+ public base::NonThreadSafe {
public:
InMemoryHostConfig();
virtual ~InMemoryHostConfig();
// MutableHostConfig interface.
virtual bool GetString(const std::string& path,
- std::string* out_value) OVERRIDE;
- virtual bool GetBoolean(const std::string& path, bool* out_value) OVERRIDE;
+ std::string* out_value) const OVERRIDE;
+ virtual bool GetBoolean(const std::string& path,
+ bool* out_value) const OVERRIDE;
virtual void SetString(const std::string& path,
const std::string& in_value) OVERRIDE;
virtual void SetBoolean(const std::string& path, bool in_value) OVERRIDE;
- virtual void Save() OVERRIDE;
+ virtual bool Save() OVERRIDE;
protected:
- // |lock_| must be locked whenever |values_| is used.
- base::Lock lock_;
scoped_ptr<base::DictionaryValue> values_;
private:
« no previous file with comments | « remoting/host/host_key_pair_unittest.cc ('k') | remoting/host/in_memory_host_config.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698