Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: remoting/host/in_memory_host_config.h

Issue 10007048: Cleanup and simplify HostConfig and JsonHostConfig. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « remoting/host/host_key_pair_unittest.cc ('k') | remoting/host/in_memory_host_config.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef REMOTING_HOST_IN_MEMORY_HOST_CONFIG_H_ 5 #ifndef REMOTING_HOST_IN_MEMORY_HOST_CONFIG_H_
6 #define REMOTING_HOST_IN_MEMORY_HOST_CONFIG_H_ 6 #define REMOTING_HOST_IN_MEMORY_HOST_CONFIG_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/ref_counted.h"
11 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
12 #include "base/synchronization/lock.h" 11 #include "base/threading/non_thread_safe.h"
13 #include "remoting/host/host_config.h" 12 #include "remoting/host/host_config.h"
14 13
15 namespace base { 14 namespace base {
16 class DictionaryValue; 15 class DictionaryValue;
17 } 16 } // namespace base
18 17
19 namespace remoting { 18 namespace remoting {
20 19
21 // In-memory host config. Used by unittests. 20 // In-memory host config. Used by unittests.
22 class InMemoryHostConfig : public MutableHostConfig { 21 class InMemoryHostConfig : public MutableHostConfig,
22 public base::NonThreadSafe {
23 public: 23 public:
24 InMemoryHostConfig(); 24 InMemoryHostConfig();
25 virtual ~InMemoryHostConfig(); 25 virtual ~InMemoryHostConfig();
26 26
27 // MutableHostConfig interface. 27 // MutableHostConfig interface.
28 virtual bool GetString(const std::string& path, 28 virtual bool GetString(const std::string& path,
29 std::string* out_value) OVERRIDE; 29 std::string* out_value) const OVERRIDE;
30 virtual bool GetBoolean(const std::string& path, bool* out_value) OVERRIDE; 30 virtual bool GetBoolean(const std::string& path,
31 bool* out_value) const OVERRIDE;
31 32
32 virtual void SetString(const std::string& path, 33 virtual void SetString(const std::string& path,
33 const std::string& in_value) OVERRIDE; 34 const std::string& in_value) OVERRIDE;
34 virtual void SetBoolean(const std::string& path, bool in_value) OVERRIDE; 35 virtual void SetBoolean(const std::string& path, bool in_value) OVERRIDE;
35 36
36 virtual void Save() OVERRIDE; 37 virtual bool Save() OVERRIDE;
37 38
38 protected: 39 protected:
39 // |lock_| must be locked whenever |values_| is used.
40 base::Lock lock_;
41 scoped_ptr<base::DictionaryValue> values_; 40 scoped_ptr<base::DictionaryValue> values_;
42 41
43 private: 42 private:
44 DISALLOW_COPY_AND_ASSIGN(InMemoryHostConfig); 43 DISALLOW_COPY_AND_ASSIGN(InMemoryHostConfig);
45 }; 44 };
46 45
47 } // namespace remoting 46 } // namespace remoting
48 47
49 #endif // REMOTING_HOST_IN_MEMORY_HOST_CONFIG_H_ 48 #endif // REMOTING_HOST_IN_MEMORY_HOST_CONFIG_H_
OLDNEW
« no previous file with comments | « remoting/host/host_key_pair_unittest.cc ('k') | remoting/host/in_memory_host_config.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698