Cleanup and simplify HostConfig and JsonHostConfig.

remoting/host/json_host_config.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/json_host_config.h"
 
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/location.h"
-#include "base/message_loop_proxy.h"
-#include "base/synchronization/lock.h"
 #include "base/values.h"
 
 namespace remoting {
 
-JsonHostConfig::JsonHostConfig(
-    const FilePath& filename,
-    base::MessageLoopProxy* file_message_loop_proxy)
-    : filename_(filename),
-      message_loop_proxy_(file_message_loop_proxy) {
+JsonHostConfig::JsonHostConfig(const FilePath& filename)
+    : filename_(filename) {
 }
 
 JsonHostConfig::~JsonHostConfig() {}
 
 bool JsonHostConfig::Read() {
+  DCHECK(CalledOnValidThread());
+
   // TODO(sergeyu): Implement better error handling here.
   std::string file_content;
   if (!file_util::ReadFileToString(filename_, &file_content)) {
     return false;
   }
 
   scoped_ptr<Value> value(base::JSONReader::Read(file_content, true));
   if (value.get() == NULL || !value->IsType(Value::TYPE_DICTIONARY)) {
     return false;
   }
 
   DictionaryValue* dictionary = static_cast<DictionaryValue*>(value.release());
-  base::AutoLock auto_lock(lock_);
   values_.reset(dictionary);
   return true;
 }
 
-void JsonHostConfig::Save() {
-  message_loop_proxy_->PostTask(
-      FROM_HERE, base::Bind(&JsonHostConfig::DoWrite, this));
-}
+bool JsonHostConfig::Save() {
+  DCHECK(CalledOnValidThread());
 
-void JsonHostConfig::DoWrite() {
   std::string file_content;
-  base::AutoLock auto_lock(lock_);
   base::JSONWriter::WriteWithOptions(values_.get(),
                                      base::JSONWriter::OPTIONS_PRETTY_PRINT,
                                      &file_content);
   // TODO(sergeyu): Move ImportantFileWriter to base and use it here.
-  file_util::WriteFile(filename_, file_content.c_str(), file_content.size());
+  return file_util::WriteFile(filename_, file_content.c_str(),
+                              file_content.size());

[Lambros, 2012/04/06 22:26:46]

WriteFile returns int: number of bytes written, or -1 on error.  Simple cast to
bool is not correct. I think, for our purposes, it is sufficient to treat
partial write as error.

[Sergey Ulanov, 2012/04/06 22:32:53]

Done.

 }
 
 }  // namespace remoting