Use preallocated StackOverflowException

Use a preallocated StackOverflowException rather than allocating one
while our stack is hurting.  This allows us to get rid of the stack
tweaking which we do in this case.
Committed: https://code.google.com/p/dart/source/detail?r=2149

[turnidge, 2011-12-06 19:59:26]

Pretty simple review, hopefully.

[siva, 2011-12-06 20:44:05]

lgtm

http://codereview.chromium.org/8823001/diff/3001/runtime/vm/object_store.cc
File runtime/vm/object_store.cc (right):

http://codereview.chromium.org/8823001/diff/3001/runtime/vm/object_store.cc#n...
runtime/vm/object_store.cc:83:
Instance::Handle(Exceptions::Create(Exceptions::kStackOverflow, args));
Since this runs dart code there is a possibility that this code could do a
longjmp. Is long_jmp_base set at this point?

I am also wondering if this function should return an error when that happens
and we could return that error from CheckIsolateState.

[turnidge, 2011-12-06 22:51:09]

http://codereview.chromium.org/8823001/diff/3001/runtime/vm/object_store.cc
File runtime/vm/object_store.cc (right):

http://codereview.chromium.org/8823001/diff/3001/runtime/vm/object_store.cc#n...
runtime/vm/object_store.cc:83:
Instance::Handle(Exceptions::Create(Exceptions::kStackOverflow, args));
On 2011/12/06 20:44:05, asiva wrote:
> Since this runs dart code there is a possibility that this code could do a
> longjmp. Is long_jmp_base set at this point?
> 
> I am also wondering if this function should return an error when that happens
> and we could return that error from CheckIsolateState.

Added LongJump around the call.  The error is propagated to the caller in
object_store->sticky_error().  Changed the caller to check this value.