Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 8823001: Use preallocated StackOverflowException (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_generator.cc ('k') | runtime/vm/isolate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl.cc
===================================================================
--- runtime/vm/dart_api_impl.cc (revision 2103)
+++ runtime/vm/dart_api_impl.cc (working copy)
@@ -56,10 +56,15 @@
static const char* CheckIsolateState(
Isolate* isolate,
bool generating_snapshot = ClassFinalizer::kNotGeneratingSnapshot) {
- bool result = (generating_snapshot) ?
+ bool success = (generating_snapshot) ?
ClassFinalizer::FinalizePendingClassesForSnapshotCreation() :
ClassFinalizer::FinalizePendingClasses();
- if (!result) {
+ if (success && !generating_snapshot) {
+ success = isolate->object_store()->PreallocateObjects();
+ }
+ if (success) {
+ return NULL;
+ } else {
// Make a copy of the error message as the original message string
// may get deallocated when we return back from the Dart API call.
const String& err =
@@ -70,7 +75,6 @@
OS::SNPrint(msg, errlen, "%s", errmsg);
return msg;
}
- return NULL;
}
« no previous file with comments | « runtime/vm/code_generator.cc ('k') | runtime/vm/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698