Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: runtime/vm/code_generator.cc

Issue 8823001: Use preallocated StackOverflowException (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_generator.cc
===================================================================
--- runtime/vm/code_generator.cc (revision 2103)
+++ runtime/vm/code_generator.cc (working copy)
@@ -829,13 +829,12 @@
DEFINE_RUNTIME_ENTRY(StackOverflow, 0) {
ASSERT(arguments.Count() ==
kStackOverflowRuntimeEntry.argument_count());
- uword old_stack_limit = isolate->stack_limit();
- isolate->AdjustStackLimitForException();
- // Recursive stack overflow check.
- ASSERT(old_stack_limit != isolate->stack_limit());
- GrowableArray<const Object*> args;
- Exceptions::ThrowByType(Exceptions::kStackOverflow, args);
- isolate->ResetStackLimitAfterException();
+ // Use a preallocated stack overflow exception to avoid calling into
+ // dart code.
+ const Instance& exception =
+ Instance::Handle(isolate->object_store()->stack_overflow());
+ Exceptions::Throw(exception);
+ UNREACHABLE();
}
« no previous file with comments | « no previous file | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698