Use preallocated StackOverflowException

runtime/vm/object_store.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object_store.h"
 
+#include "vm/exceptions.h"
 #include "vm/isolate.h"
 #include "vm/object.h"
 #include "vm/raw_object.h"
 #include "vm/visitor.h"
 
 namespace dart {
 
 ObjectStore::ObjectStore()
   : object_class_(Class::null()),
     function_interface_(Type::null()),
@@ skipping 24 matching lines @@
     false_value_(Bool::null()),
     empty_array_(Array::null()),
     symbol_table_(Array::null()),
     core_library_(Library::null()),
     core_impl_library_(Library::null()),
     native_wrappers_library_(Library::null()),
     root_library_(Library::null()),
     registered_libraries_(Library::null()),
     pending_classes_(Array::null()),
     sticky_error_(String::null()),
-    empty_context_(Context::null()) {
+    empty_context_(Context::null()),
+    stack_overflow_(Instance::null()),
+    preallocate_objects_called_(false) {
 }
 
 
 ObjectStore::~ObjectStore() {
 }
 
 
 void ObjectStore::VisitObjectPointers(ObjectPointerVisitor* visitor) {
   ASSERT(visitor != NULL);
   visitor->VisitPointers(from(), to());
 }
 
 
 void ObjectStore::Init(Isolate* isolate) {
   ASSERT(isolate->object_store() == NULL);
   ObjectStore* store = new ObjectStore();
   isolate->set_object_store(store);
 }
 
 
+void ObjectStore::PreallocateObjects() {
+  if (preallocate_objects_called_) {
+    return;
+  }
+  preallocate_objects_called_ = true;
+
+  GrowableArray<const Object*> args;
+  const Instance& exception =
+      Instance::Handle(Exceptions::Create(Exceptions::kStackOverflow, args));

[siva, 2011/12/06 20:44:05]

Since this runs dart code there is a possibility that this code could do a
longjmp. Is long_jmp_base set at this point?

I am also wondering if this function should return an error when that happens
and we could return that error from CheckIsolateState.

[turnidge, 2011/12/06 22:51:09]

Added LongJump around the call.  The error is propagated to the caller in
object_store->sticky_error().  Changed the caller to check this value.

+  set_stack_overflow(exception);
+}
+
+
 RawClass* ObjectStore::GetClass(int index) {
   switch (index) {
     case kObjectClass: return object_class_;
     case kSmiClass: return smi_class_;
     case kMintClass: return mint_class_;
     case kBigintClass: return bigint_class_;
     case kDoubleClass: return double_class_;
     case kOneByteStringClass: return one_byte_string_class_;
     case kTwoByteStringClass: return two_byte_string_class_;
     case kFourByteStringClass: return four_byte_string_class_;
@@ skipping 99 matching lines @@
     return kBoolInterface;
   } else if (raw_type == string_interface()) {
     return kStringInterface;
   } else if (raw_type == list_interface()) {
     return kListInterface;
   }
   return kInvalidIndex;
 }
 
 }  // namespace dart