Issue 8386029: Consistently use setters to set event handlers in native APIs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8386029: Consistently use setters to set event handlers in native APIs. (Closed)

Created:
9 years, 1 month ago by Mads Ager (google)

Modified:
9 years, 1 month ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Consistently use setters to set event handlers in native APIs. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1083

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+99 lines, -99 lines)			Patch
M	runtime/bin/directory.dart	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	runtime/bin/directory_impl.dart	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	runtime/bin/process.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/process_impl.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/socket.dart	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	runtime/bin/socket_impl.dart	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	runtime/bin/socket_stream.dart	View	5 chunks	+10 lines, -10 lines	0 comments	Download
M	samples/chat/http_impl.dart	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	tests/standalone/src/DirectoryInvalidArgumentsTest.dart	View	1 chunk	+7 lines, -7 lines	0 comments	Download
M	tests/standalone/src/DirectoryTest.dart	View	2 chunks	+13 lines, -13 lines	0 comments	Download
M	tests/standalone/src/EchoServerStreamTest.dart	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	tests/standalone/src/EchoServerTest.dart	View	6 chunks	+13 lines, -13 lines	0 comments	Download
M	tests/standalone/src/SocketCloseTest.dart	View	4 chunks	+9 lines, -9 lines	0 comments	Download
M	tests/standalone/src/SocketManyConnectionsTest.dart	View	3 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 2 (0 generated)

lgtm