Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: tests/standalone/src/SocketCloseTest.dart

Issue 8386029: Consistently use setters to set event handlers in native APIs. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/src/EchoServerTest.dart ('k') | tests/standalone/src/SocketManyConnectionsTest.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/src/SocketCloseTest.dart
diff --git a/tests/standalone/src/SocketCloseTest.dart b/tests/standalone/src/SocketCloseTest.dart
index 89369ea896ef42a8d7744dda0a3e20e71405ba9a..b7a747f967f76d462f45fe3098385ae21189f140 100644
--- a/tests/standalone/src/SocketCloseTest.dart
+++ b/tests/standalone/src/SocketCloseTest.dart
@@ -53,9 +53,9 @@ class SocketClose {
}
void connectHandler() {
- _socket.setDataHandler(dataHandler);
- _socket.setCloseHandler(closeHandler);
- _socket.setErrorHandler(errorHandler);
+ _socket.dataHandler = dataHandler;
+ _socket.closeHandler = closeHandler;
+ _socket.errorHandler = errorHandler;
if ((_iterations % 2) == 0) {
_socket.writeList("Hello".charCodes(), 0, 5);
@@ -64,7 +64,7 @@ class SocketClose {
_socket = new Socket(SocketCloseServer.HOST, _port);
Expect.equals(true, _socket !== null);
- _socket.setConnectHandler(connectHandler);
+ _socket.connectHandler = connectHandler;
}
void start() {
@@ -128,9 +128,9 @@ class SocketCloseServer extends Isolate {
if ((_iterations % 2) == 1) {
_client.close();
}
- _client.setDataHandler(messageHandler);
- _client.setCloseHandler(closeHandler);
- _client.setErrorHandler(errorHandler);
+ _client.dataHandler = messageHandler;
+ _client.closeHandler = closeHandler;
+ _client.errorHandler = errorHandler;
_iterations++;
}
@@ -146,8 +146,8 @@ class SocketCloseServer extends Isolate {
_iterations = 0;
_server = new ServerSocket(HOST, 0, 10);
Expect.equals(true, _server !== null);
- _server.setConnectionHandler(connectionHandler);
- _server.setErrorHandler(errorHandlerServer);
+ _server.connectionHandler = connectionHandler;
+ _server.errorHandler = errorHandlerServer;
replyTo.send(_server.port, null);
} else if (message == SocketClose.SERVERSHUTDOWN) {
Expect.equals(SocketClose.ITERATIONS/2, _dataEvents);
« no previous file with comments | « tests/standalone/src/EchoServerTest.dart ('k') | tests/standalone/src/SocketManyConnectionsTest.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698