Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Unified Diff: runtime/bin/directory_impl.dart

Issue 8386029: Consistently use setters to set event handlers in native APIs. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/directory.dart ('k') | runtime/bin/process.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/directory_impl.dart
diff --git a/runtime/bin/directory_impl.dart b/runtime/bin/directory_impl.dart
index a1ecfdb000d1f04eff5cc2262157b208f6c078b9..4e962e41e1e9f50d5f623f02262120a82f6d2ad7 100644
--- a/runtime/bin/directory_impl.dart
+++ b/runtime/bin/directory_impl.dart
@@ -33,7 +33,7 @@ class _Directory implements Directory {
_Directory(String this._path);
- bool exists() {
+ bool existsSync() {
int exists = _exists(_path);
if (exists < 0) {
// TODO(ager): Supply a better error message.
@@ -42,14 +42,14 @@ class _Directory implements Directory {
return (exists == 1);
}
- void create() {
+ void createSync() {
if (!_create(_path)) {
// TODO(ager): Supply a better error message.
throw new DirectoryException("Directory creation failed: $_path");
}
}
- void delete() {
+ void deleteSync() {
if (!_delete(_path)) {
// TODO(ager): Supply a better error message.
throw new DirectoryException("Directory deletion failed: $_path");
@@ -120,19 +120,19 @@ class _Directory implements Directory {
});
}
- void setDirHandler(void dirHandler(String dir)) {
+ void set dirHandler(void dirHandler(String dir)) {
_dirHandler = dirHandler;
}
- void setFileHandler(void fileHandler(String file)) {
+ void set fileHandler(void fileHandler(String file)) {
_fileHandler = fileHandler;
}
- void setDoneHandler(void doneHandler(bool completed)) {
+ void set doneHandler(void doneHandler(bool completed)) {
_doneHandler = doneHandler;
}
- void setErrorHandler(void errorHandler(String error)) {
+ void set errorHandler(void errorHandler(String error)) {
_errorHandler = errorHandler;
}
« no previous file with comments | « runtime/bin/directory.dart ('k') | runtime/bin/process.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698