Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Unified Diff: tests/standalone/src/EchoServerTest.dart

Issue 8386029: Consistently use setters to set event handlers in native APIs. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/src/EchoServerStreamTest.dart ('k') | tests/standalone/src/SocketCloseTest.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/src/EchoServerTest.dart
diff --git a/tests/standalone/src/EchoServerTest.dart b/tests/standalone/src/EchoServerTest.dart
index eeae75ef7bb421d597f7fcc528a589e1a026571b..23065628c207490bf2e3c872e231fd04a8ae0551 100644
--- a/tests/standalone/src/EchoServerTest.dart
+++ b/tests/standalone/src/EchoServerTest.dart
@@ -54,7 +54,7 @@ class EchoServerGame {
for (int i = 0; i < bytesRead; i++) {
Expect.equals(FIRSTCHAR + i, bufferReceived[i]);
}
- _socket.setDataHandler(handleRead);
+ _socket.dataHandler = handleRead;
} else {
// We check every time the whole buffer to verify data integrity.
for (int i = 0; i < MSGSIZE; i++) {
@@ -91,22 +91,22 @@ class EchoServerGame {
bytesWritten += _socket.writeList(
_buffer, bytesWritten, MSGSIZE - bytesWritten);
if (bytesWritten < MSGSIZE) {
- _socket.setWriteHandler(handleWrite);
+ _socket.writeHandler = handleWrite;
}
}
handleWrite();
}
- _socket.setDataHandler(messageHandler);
- _socket.setCloseHandler(closeHandler);
- _socket.setErrorHandler(errorHandler);
+ _socket.dataHandler = messageHandler;
+ _socket.closeHandler = closeHandler;
+ _socket.errorHandler = errorHandler;
writeMessage();
}
_socket = new Socket(EchoServer.HOST, _port);
if (_socket !== null) {
- _socket.setConnectHandler(connectHandler);
+ _socket.connectHandler = connectHandler;
} else {
Expect.fail("socket creation failed");
}
@@ -157,7 +157,7 @@ class EchoServer extends Isolate {
for (int i = 0; i < bytesRead; i++) {
Expect.equals(EchoServerGame.FIRSTCHAR + i, buffer[i]);
}
- _client.setDataHandler(handleRead);
+ _client.dataHandler = handleRead;
} else {
// We check every time the whole buffer to verify data integrity.
for (int i = 0; i < msgSize; i++) {
@@ -173,7 +173,7 @@ class EchoServer extends Isolate {
buffer, bytesWritten, msgSize - bytesWritten);
bytesWritten += written;
if (bytesWritten < msgSize) {
- _client.setWriteHandler(handleWrite);
+ _client.writeHandler = handleWrite;
}
}
handleWrite();
@@ -196,9 +196,9 @@ class EchoServer extends Isolate {
}
_client = _server.accept();
- _client.setDataHandler(messageHandler);
- _client.setCloseHandler(closeHandler);
- _client.setErrorHandler(errorHandler);
+ _client.dataHandler = messageHandler;
+ _client.closeHandler = closeHandler;
+ _client.errorHandler = errorHandler;
}
void errorHandlerServer() {
@@ -210,8 +210,8 @@ class EchoServer extends Isolate {
if (message == EchoServerGame.SERVERINIT) {
_server = new ServerSocket(HOST, 0, 10);
Expect.equals(true, _server !== null);
- _server.setConnectionHandler(connectionHandler);
- _server.setErrorHandler(errorHandlerServer);
+ _server.connectionHandler = connectionHandler;
+ _server.errorHandler = errorHandlerServer;
replyTo.send(_server.port, null);
} else if (message == EchoServerGame.SERVERSHUTDOWN) {
_server.close();
« no previous file with comments | « tests/standalone/src/EchoServerStreamTest.dart ('k') | tests/standalone/src/SocketCloseTest.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698