Remove Page.CanRunOnBrowser hook

Remove Page.CanRunOnBrowser hook

BUG=468085
Committed: https://crrev.com/701f20c5d1d912992f1d3d6eea453c0658641671
Cr-Commit-Position: refs/heads/master@{#321520}

[nednguyen, 2015-03-19 22:54:36]

nednguyen@google.com changed reviewers:
+ aiolos@chromium.org, sullivan@chromium.org

[sullivan, 2015-03-20 01:25:17]

https://codereview.chromium.org/999643003/diff/1/tools/telemetry/telemetry/pa...
File tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py (right):

https://codereview.chromium.org/999643003/diff/1/tools/telemetry/telemetry/pa...
tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py:417: # Ensure
skipping the test if page cannot be run on the browser.
Is the naming of the test and wording in the comments here still correct? From
the bug, it sounds like we don't want the functionality that a specific page can
be removed for some browsers or platforms, but this test looks like it does
exactly that?

[nednguyen, 2015-03-20 01:43:24]

https://codereview.chromium.org/999643003/diff/1/tools/telemetry/telemetry/pa...
File tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py (right):

https://codereview.chromium.org/999643003/diff/1/tools/telemetry/telemetry/pa...
tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py:417: # Ensure
skipping the test if page cannot be run on the browser.
On 2015/03/20 01:25:17, sullivan wrote:
> Is the naming of the test and wording in the comments here still correct? From
> the bug, it sounds like we don't want the functionality that a specific page
can
> be removed for some browsers or platforms, but this test looks like it does
> exactly that?

Ah, I think the comment's wording doesn't reflect the new model exactly. This
test is about testing that the UnrunnableSharedState would skip the run.

[sullivan, 2015-03-20 01:44:42]

On 2015/03/20 01:43:24, nednguyen wrote:
>
https://codereview.chromium.org/999643003/diff/1/tools/telemetry/telemetry/pa...
> File tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py (right):
> 
>
https://codereview.chromium.org/999643003/diff/1/tools/telemetry/telemetry/pa...
> tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py:417: # Ensure
> skipping the test if page cannot be run on the browser.
> On 2015/03/20 01:25:17, sullivan wrote:
> > Is the naming of the test and wording in the comments here still correct?
From
> > the bug, it sounds like we don't want the functionality that a specific page
> can
> > be removed for some browsers or platforms, but this test looks like it does
> > exactly that?
> 
> Ah, I think the comment's wording doesn't reflect the new model exactly. This
> test is about testing that the UnrunnableSharedState would skip the run.

Great, lgtm after updating comment/naming

[nednguyen, 2015-03-20 02:04:55]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2015-03-20 02:04:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
sullivan@chromium.org
Link to the patchset: https://codereview.chromium.org/999643003/#ps20001 (title:
"Update test name ")

[commit-bot: I haz the power, 2015-03-20 02:05:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/999643003/20001

[commit-bot: I haz the power, 2015-03-20 05:19:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-20 05:20:51]

Patchset 2 (id:??) landed as
https://crrev.com/701f20c5d1d912992f1d3d6eea453c0658641671
Cr-Commit-Position: refs/heads/master@{#321520}