tools/telemetry/telemetry/page/shared_page_state.py - Issue 999643003: Remove Page.CanRunOnBrowser hook

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/shared_page_state.py

Issue 999643003: Remove Page.CanRunOnBrowser hook (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update test name Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/shared_page_state.py

diff --git a/tools/telemetry/telemetry/page/shared_page_state.py b/tools/telemetry/telemetry/page/shared_page_state.py

index 99a14aebab2e61c4af280ddb67a17662f9220984..0e564f8f8eac99a3b5eb2019556ba62a37bba81e 100644

--- a/tools/telemetry/telemetry/page/shared_page_state.py

+++ b/tools/telemetry/telemetry/page/shared_page_state.py

@@ -205,15 +205,6 @@ class SharedPageState(shared_user_story_state.SharedUserStoryState):

'Skipped because browser is not supported '

'(page.CanRunOnBrowser() returns False).')

return 'skip', skip_value

- #TODO(nednguyen): Remove this code block when page.CanRunOnBrowser hook is

- # removed. (crbug.com/468085)

- if not self._current_page.CanRunOnBrowser(

- browser_info_module.BrowserInfo(self.browser)):

- skip_value = skip.SkipValue(

- self._current_page,

- 'Skipped because browser is not supported '

- '(page.CanRunOnBrowser() returns False).')

- return 'skip', skip_value

expectation = expectations.GetExpectationForPage(

self.browser, self._current_page)

if expectation == 'skip':

« no previous file with comments | « tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py ('k') | no next file » | no next file with comments »