Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Unified Diff: tools/telemetry/telemetry/page/__init__.py

Issue 999643003: Remove Page.CanRunOnBrowser hook (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update test name Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/__init__.py
diff --git a/tools/telemetry/telemetry/page/__init__.py b/tools/telemetry/telemetry/page/__init__.py
index eee9f4ad4c323d4a21ac0c05432b14749f119ca8..8aa65abeba0e3fb0f42b84206566ec72b4b064cd 100644
--- a/tools/telemetry/telemetry/page/__init__.py
+++ b/tools/telemetry/telemetry/page/__init__.py
@@ -110,17 +110,6 @@ class Page(user_story.UserStory):
"""
pass
- # Deprecated. Do not use this hook. (crbug.com/468085)
- def CanRunOnBrowser(self, browser_info):
- """Override this to returns whether this page can be run on specific
- browser.
-
- Args:
- browser_info: an instance of telemetry.core.browser_info.BrowserInfo
- """
- assert browser_info
- return True
-
def AsDict(self):
"""Converts a page object to a dict suitable for JSON output."""
d = {
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698