Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 998903003: Fix bug with very large round rects with large radii (Closed)

Created:
5 years, 9 months ago by robertphillips
Modified:
5 years, 9 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix bug with very large round rects with large radii BUG=463920 Committed: https://skia.googlesource.com/skia/+/2a679ae8f5b80a337f67783dbc0a447a9f4312c7

Patch Set 1 #

Patch Set 2 : Update #

Total comments: 4

Patch Set 3 : Address code review comments #

Total comments: 2

Patch Set 4 : Added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -25 lines) Patch
M src/core/SkRRect.cpp View 1 2 3 2 chunks +16 lines, -18 lines 0 comments Download
M tests/RoundRectTest.cpp View 1 2 chunks +24 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
robertphillips
https://codereview.chromium.org/998903003/diff/20001/src/core/SkRRect.cpp File src/core/SkRRect.cpp (right): https://codereview.chromium.org/998903003/diff/20001/src/core/SkRRect.cpp#newcode175 src/core/SkRRect.cpp:175: // If f < 1, then all corner radii ...
5 years, 9 months ago (2015-03-11 18:13:28 UTC) #2
robertphillips
ping
5 years, 9 months ago (2015-03-13 13:51:09 UTC) #3
reed1
https://codereview.chromium.org/998903003/diff/20001/src/core/SkRRect.cpp File src/core/SkRRect.cpp (right): https://codereview.chromium.org/998903003/diff/20001/src/core/SkRRect.cpp#newcode178 src/core/SkRRect.cpp:178: if (fRadii[0].fX + ((double)fRadii[1].fX) > rect.width()) { can we ...
5 years, 9 months ago (2015-03-13 14:16:21 UTC) #4
robertphillips
https://codereview.chromium.org/998903003/diff/20001/src/core/SkRRect.cpp File src/core/SkRRect.cpp (right): https://codereview.chromium.org/998903003/diff/20001/src/core/SkRRect.cpp#newcode178 src/core/SkRRect.cpp:178: if (fRadii[0].fX + ((double)fRadii[1].fX) > rect.width()) { On 2015/03/13 ...
5 years, 9 months ago (2015-03-13 16:32:35 UTC) #5
reed1
lgtm w/ request for comment explaining the doubles in the helper. https://codereview.chromium.org/998903003/diff/40001/src/core/SkRRect.cpp File src/core/SkRRect.cpp (right): ...
5 years, 9 months ago (2015-03-13 16:41:53 UTC) #6
robertphillips
https://codereview.chromium.org/998903003/diff/40001/src/core/SkRRect.cpp File src/core/SkRRect.cpp (right): https://codereview.chromium.org/998903003/diff/40001/src/core/SkRRect.cpp#newcode131 src/core/SkRRect.cpp:131: static double compute_min_scale(double rad1, double rad2, double limit, double ...
5 years, 9 months ago (2015-03-13 16:46:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/998903003/60001
5 years, 9 months ago (2015-03-13 16:46:42 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 16:53:12 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/2a679ae8f5b80a337f67783dbc0a447a9f4312c7

Powered by Google App Engine
This is Rietveld 408576698