Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 998513002: Revert of Remove OneClickSigninHelper since it is no longer used. (Closed)

Created:
5 years, 9 months ago by rmcilroy
Modified:
5 years, 9 months ago
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, tfarina, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ocl
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove OneClickSigninHelper since it is no longer used. (patchset #5 id:340001 of https://codereview.chromium.org/914363003/) Reason for revert: Broke the tab_switching.tough_energy_cases benchmark on the perf bots. BUG=465692 Original issue's description: > Remove OneClickSigninHelper since it is no longer used. > > BUG=260022, 350202 > > Committed: https://crrev.com/be592667bdf919fb8292c88c1b59767add856ba4 > Cr-Commit-Position: refs/heads/master@{#319662} TBR=noms@chromium.org,asvitkine@chromium.org,sky@chromium.org,rogerta@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=260022, 350202 Committed: https://crrev.com/861ae783973af63043c05ebe3ba250cc36c45c3d Cr-Commit-Position: refs/heads/master@{#319862}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2901 lines, -528 lines) Patch
M chrome/browser/chrome_browser_field_trials_desktop.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 5 chunks +49 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/one_click_signin_view_controller.mm View 7 chunks +7 lines, -6 lines 0 comments Download
A chrome/browser/ui/sync/one_click_signin_helper.h View 1 chunk +380 lines, -0 lines 0 comments Download
A chrome/browser/ui/sync/one_click_signin_helper.cc View 1 chunk +1433 lines, -0 lines 0 comments Download
A chrome/browser/ui/sync/one_click_signin_helper_unittest.cc View 1 chunk +986 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc View 7 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_handler_impl.h View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_handler_impl.cc View 12 chunks +23 lines, -339 lines 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc View 4 chunks +1 line, -148 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M components/signin/core/browser/signin_metrics.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/signin/core/browser/signin_metrics.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rmcilroy
Created Revert of Remove OneClickSigninHelper since it is no longer used.
5 years, 9 months ago (2015-03-10 11:59:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/998513002/1
5 years, 9 months ago (2015-03-10 12:00:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 12:00:49 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 12:01:39 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/861ae783973af63043c05ebe3ba250cc36c45c3d
Cr-Commit-Position: refs/heads/master@{#319862}

Powered by Google App Engine
This is Rietveld 408576698