Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

Issue 998513002: Revert of Remove OneClickSigninHelper since it is no longer used. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ocl
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/sync/one_click_signin_bubble_view.h" 5 #include "chrome/browser/ui/views/sync/one_click_signin_bubble_view.h"
6 6
7 #include "base/callback_helpers.h" 7 #include "base/callback_helpers.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "chrome/browser/ui/browser.h" 9 #include "chrome/browser/ui/browser.h"
10 #include "chrome/browser/ui/sync/one_click_signin_helper.h"
10 #include "chrome/common/url_constants.h" 11 #include "chrome/common/url_constants.h"
11 #include "chrome/grit/chromium_strings.h" 12 #include "chrome/grit/chromium_strings.h"
12 #include "chrome/grit/generated_resources.h" 13 #include "chrome/grit/generated_resources.h"
13 #include "components/google/core/browser/google_util.h" 14 #include "components/google/core/browser/google_util.h"
14 #include "grit/components_strings.h" 15 #include "grit/components_strings.h"
15 #include "ui/base/l10n/l10n_util.h" 16 #include "ui/base/l10n/l10n_util.h"
16 #include "ui/base/resource/resource_bundle.h" 17 #include "ui/base/resource/resource_bundle.h"
17 #include "ui/events/keycodes/keyboard_codes.h" 18 #include "ui/events/keycodes/keyboard_codes.h"
18 #include "ui/resources/grit/ui_resources.h" 19 #include "ui/resources/grit/ui_resources.h"
19 #include "ui/views/controls/button/image_button.h" 20 #include "ui/views/controls/button/image_button.h"
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 201
201 layout->AddPaddingRow(0, views::kUnrelatedControlVerticalSpacing); 202 layout->AddPaddingRow(0, views::kUnrelatedControlVerticalSpacing);
202 203
203 layout->StartRow(0, COLUMN_SET_CONTROLS); 204 layout->StartRow(0, COLUMN_SET_CONTROLS);
204 205
205 InitLearnMoreLink(); 206 InitLearnMoreLink();
206 layout->AddView(learn_more_link_); 207 layout->AddView(learn_more_link_);
207 } 208 }
208 209
209 void OneClickSigninBubbleView::InitDialogContent(views::GridLayout* layout) { 210 void OneClickSigninBubbleView::InitDialogContent(views::GridLayout* layout) {
210 signin_metrics::LogSigninConfirmHistogramValue( 211 OneClickSigninHelper::LogConfirmHistogramValue(
211 signin_metrics::HISTOGRAM_CONFIRM_SHOWN); 212 signin_metrics::HISTOGRAM_CONFIRM_SHOWN);
212 213
213 // Column set for title bar. 214 // Column set for title bar.
214 views::ColumnSet* cs = layout->AddColumnSet(COLUMN_SET_TITLE_BAR); 215 views::ColumnSet* cs = layout->AddColumnSet(COLUMN_SET_TITLE_BAR);
215 cs->AddColumn(views::GridLayout::LEADING, views::GridLayout::CENTER, 0, 216 cs->AddColumn(views::GridLayout::LEADING, views::GridLayout::CENTER, 0,
216 views::GridLayout::USE_PREF, 0, 0); 217 views::GridLayout::USE_PREF, 0, 0);
217 cs->AddPaddingColumn(1, views::kUnrelatedControlHorizontalSpacing); 218 cs->AddPaddingColumn(1, views::kUnrelatedControlHorizontalSpacing);
218 cs->AddColumn(views::GridLayout::TRAILING, views::GridLayout::CENTER, 0, 219 cs->AddColumn(views::GridLayout::TRAILING, views::GridLayout::CENTER, 0,
219 views::GridLayout::USE_PREF, 0, 0); 220 views::GridLayout::USE_PREF, 0, 0);
220 221
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
311 } 312 }
312 313
313 bool OneClickSigninBubbleView::AcceleratorPressed( 314 bool OneClickSigninBubbleView::AcceleratorPressed(
314 const ui::Accelerator& accelerator) { 315 const ui::Accelerator& accelerator) {
315 if (accelerator.key_code() == ui::VKEY_RETURN || 316 if (accelerator.key_code() == ui::VKEY_RETURN ||
316 accelerator.key_code() == ui::VKEY_ESCAPE) { 317 accelerator.key_code() == ui::VKEY_ESCAPE) {
317 OneClickSigninBubbleView::Hide(); 318 OneClickSigninBubbleView::Hide();
318 319
319 if (is_sync_dialog_) { 320 if (is_sync_dialog_) {
320 if (accelerator.key_code() == ui::VKEY_RETURN) { 321 if (accelerator.key_code() == ui::VKEY_RETURN) {
321 signin_metrics::LogSigninConfirmHistogramValue( 322 OneClickSigninHelper::LogConfirmHistogramValue(
322 clicked_learn_more_ ? 323 clicked_learn_more_ ?
323 signin_metrics::HISTOGRAM_CONFIRM_LEARN_MORE_RETURN : 324 signin_metrics::HISTOGRAM_CONFIRM_LEARN_MORE_RETURN :
324 signin_metrics::HISTOGRAM_CONFIRM_RETURN); 325 signin_metrics::HISTOGRAM_CONFIRM_RETURN);
325 326
326 base::ResetAndReturn(&start_sync_callback_).Run( 327 base::ResetAndReturn(&start_sync_callback_).Run(
327 OneClickSigninSyncStarter::SYNC_WITH_DEFAULT_SETTINGS); 328 OneClickSigninSyncStarter::SYNC_WITH_DEFAULT_SETTINGS);
328 } else if (accelerator.key_code() == ui::VKEY_ESCAPE) { 329 } else if (accelerator.key_code() == ui::VKEY_ESCAPE) {
329 signin_metrics::LogSigninConfirmHistogramValue( 330 OneClickSigninHelper::LogConfirmHistogramValue(
330 clicked_learn_more_ ? 331 clicked_learn_more_ ?
331 signin_metrics::HISTOGRAM_CONFIRM_LEARN_MORE_ESCAPE : 332 signin_metrics::HISTOGRAM_CONFIRM_LEARN_MORE_ESCAPE :
332 signin_metrics::HISTOGRAM_CONFIRM_ESCAPE); 333 signin_metrics::HISTOGRAM_CONFIRM_ESCAPE);
333 334
334 base::ResetAndReturn(&start_sync_callback_).Run( 335 base::ResetAndReturn(&start_sync_callback_).Run(
335 OneClickSigninSyncStarter::UNDO_SYNC); 336 OneClickSigninSyncStarter::UNDO_SYNC);
336 } 337 }
337 } 338 }
338 339
339 return true; 340 return true;
340 } 341 }
341 342
342 return BubbleDelegateView::AcceleratorPressed(accelerator); 343 return BubbleDelegateView::AcceleratorPressed(accelerator);
343 } 344 }
344 345
345 void OneClickSigninBubbleView::LinkClicked(views::Link* source, 346 void OneClickSigninBubbleView::LinkClicked(views::Link* source,
346 int event_flags) { 347 int event_flags) {
347 if (source == learn_more_link_) { 348 if (source == learn_more_link_) {
348 if (is_sync_dialog_ && !clicked_learn_more_) { 349 if (is_sync_dialog_ && !clicked_learn_more_) {
349 signin_metrics::LogSigninConfirmHistogramValue( 350 OneClickSigninHelper::LogConfirmHistogramValue(
350 signin_metrics::HISTOGRAM_CONFIRM_LEARN_MORE); 351 signin_metrics::HISTOGRAM_CONFIRM_LEARN_MORE);
351 clicked_learn_more_ = true; 352 clicked_learn_more_ = true;
352 } 353 }
353 delegate_->OnLearnMoreLinkClicked(is_sync_dialog_); 354 delegate_->OnLearnMoreLinkClicked(is_sync_dialog_);
354 355
355 // don't hide the modal dialog, as this is an informational link 356 // don't hide the modal dialog, as this is an informational link
356 if (is_sync_dialog_) 357 if (is_sync_dialog_)
357 return; 358 return;
358 } else if (advanced_link_ && source == advanced_link_) { 359 } else if (advanced_link_ && source == advanced_link_) {
359 if (is_sync_dialog_) { 360 if (is_sync_dialog_) {
360 signin_metrics::LogSigninConfirmHistogramValue( 361 OneClickSigninHelper::LogConfirmHistogramValue(
361 clicked_learn_more_ ? 362 clicked_learn_more_ ?
362 signin_metrics::HISTOGRAM_CONFIRM_LEARN_MORE_ADVANCED : 363 signin_metrics::HISTOGRAM_CONFIRM_LEARN_MORE_ADVANCED :
363 signin_metrics::HISTOGRAM_CONFIRM_ADVANCED); 364 signin_metrics::HISTOGRAM_CONFIRM_ADVANCED);
364 365
365 base::ResetAndReturn(&start_sync_callback_).Run( 366 base::ResetAndReturn(&start_sync_callback_).Run(
366 OneClickSigninSyncStarter::CONFIGURE_SYNC_FIRST); 367 OneClickSigninSyncStarter::CONFIGURE_SYNC_FIRST);
367 } else { 368 } else {
368 delegate_->OnAdvancedLinkClicked(); 369 delegate_->OnAdvancedLinkClicked();
369 } 370 }
370 } 371 }
371 372
372 Hide(); 373 Hide();
373 } 374 }
374 375
375 void OneClickSigninBubbleView::ButtonPressed(views::Button* sender, 376 void OneClickSigninBubbleView::ButtonPressed(views::Button* sender,
376 const ui::Event& event) { 377 const ui::Event& event) {
377 Hide(); 378 Hide();
378 379
379 if (is_sync_dialog_) { 380 if (is_sync_dialog_) {
380 if (sender == ok_button_) 381 if (sender == ok_button_)
381 signin_metrics::LogSigninConfirmHistogramValue( 382 OneClickSigninHelper::LogConfirmHistogramValue(
382 clicked_learn_more_ ? 383 clicked_learn_more_ ?
383 signin_metrics::HISTOGRAM_CONFIRM_LEARN_MORE_OK : 384 signin_metrics::HISTOGRAM_CONFIRM_LEARN_MORE_OK :
384 signin_metrics::HISTOGRAM_CONFIRM_OK); 385 signin_metrics::HISTOGRAM_CONFIRM_OK);
385 386
386 if (sender == undo_button_) 387 if (sender == undo_button_)
387 signin_metrics::LogSigninConfirmHistogramValue( 388 OneClickSigninHelper::LogConfirmHistogramValue(
388 clicked_learn_more_ ? 389 clicked_learn_more_ ?
389 signin_metrics::HISTOGRAM_CONFIRM_LEARN_MORE_UNDO : 390 signin_metrics::HISTOGRAM_CONFIRM_LEARN_MORE_UNDO :
390 signin_metrics::HISTOGRAM_CONFIRM_UNDO); 391 signin_metrics::HISTOGRAM_CONFIRM_UNDO);
391 392
392 if (sender == close_button_) 393 if (sender == close_button_)
393 signin_metrics::LogSigninConfirmHistogramValue( 394 OneClickSigninHelper::LogConfirmHistogramValue(
394 clicked_learn_more_ ? 395 clicked_learn_more_ ?
395 signin_metrics::HISTOGRAM_CONFIRM_LEARN_MORE_CLOSE : 396 signin_metrics::HISTOGRAM_CONFIRM_LEARN_MORE_CLOSE :
396 signin_metrics::HISTOGRAM_CONFIRM_CLOSE); 397 signin_metrics::HISTOGRAM_CONFIRM_CLOSE);
397 398
398 base::ResetAndReturn(&start_sync_callback_).Run((sender == ok_button_) ? 399 base::ResetAndReturn(&start_sync_callback_).Run((sender == ok_button_) ?
399 OneClickSigninSyncStarter::SYNC_WITH_DEFAULT_SETTINGS : 400 OneClickSigninSyncStarter::SYNC_WITH_DEFAULT_SETTINGS :
400 OneClickSigninSyncStarter::UNDO_SYNC); 401 OneClickSigninSyncStarter::UNDO_SYNC);
401 } 402 }
402 } 403 }
403 404
404 void OneClickSigninBubbleView::WindowClosing() { 405 void OneClickSigninBubbleView::WindowClosing() {
405 // We have to reset |bubble_view_| here, not in our destructor, because 406 // We have to reset |bubble_view_| here, not in our destructor, because
406 // we'll be destroyed asynchronously and the shown state will be checked 407 // we'll be destroyed asynchronously and the shown state will be checked
407 // before then. 408 // before then.
408 DCHECK_EQ(bubble_view_, this); 409 DCHECK_EQ(bubble_view_, this);
409 bubble_view_ = NULL; 410 bubble_view_ = NULL;
410 411
411 if (is_sync_dialog_ && !start_sync_callback_.is_null()) { 412 if (is_sync_dialog_ && !start_sync_callback_.is_null()) {
412 base::ResetAndReturn(&start_sync_callback_).Run( 413 base::ResetAndReturn(&start_sync_callback_).Run(
413 OneClickSigninSyncStarter::UNDO_SYNC); 414 OneClickSigninSyncStarter::UNDO_SYNC);
414 } 415 }
415 } 416 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/sync/one_click_signin_helper_unittest.cc ('k') | chrome/browser/ui/webui/signin/inline_login_handler_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698