chrome/browser/ui/cocoa/one_click_signin_view_controller.mm - Issue 998513002: Revert of Remove OneClickSigninHelper since it is no longer used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/one_click_signin_view_controller.mm

Issue 998513002: Revert of Remove OneClickSigninHelper since it is no longer used. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ocl

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc ('k') | chrome/browser/ui/sync/one_click_signin_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/one_click_signin_view_controller.mm

diff --git a/chrome/browser/ui/cocoa/one_click_signin_view_controller.mm b/chrome/browser/ui/cocoa/one_click_signin_view_controller.mm

index 6ecd11ee8de8b01fd67016cc2f29f1a780c2beab..50e2931b8d6636fc51cb7af8473a81035c36b427 100644

--- a/chrome/browser/ui/cocoa/one_click_signin_view_controller.mm

+++ b/chrome/browser/ui/cocoa/one_click_signin_view_controller.mm

@@ -8,6 +8,7 @@

#include "base/logging.h"

#include "base/mac/bundle_locations.h"

#import "chrome/browser/ui/chrome_style.h"

+#include "chrome/browser/ui/sync/one_click_signin_helper.h"

#include "chrome/common/url_constants.h"

#include "chrome/grit/chromium_strings.h"

#include "chrome/grit/generated_resources.h"

@@ -77,7 +78,7 @@

- (IBAction)ok:(id)sender {

if (isSyncDialog_) {

- signin_metrics::LogSigninConfirmHistogramValue(

+ OneClickSigninHelper::LogConfirmHistogramValue(

clickedLearnMore_ ?

signin_metrics::HISTOGRAM_CONFIRM_LEARN_MORE_OK :

signin_metrics::HISTOGRAM_CONFIRM_OK);

@@ -90,7 +91,7 @@

- (IBAction)onClickUndo:(id)sender {

if (isSyncDialog_) {

- signin_metrics::LogSigninConfirmHistogramValue(

+ OneClickSigninHelper::LogConfirmHistogramValue(

clickedLearnMore_ ?

signin_metrics::HISTOGRAM_CONFIRM_LEARN_MORE_UNDO :

signin_metrics::HISTOGRAM_CONFIRM_UNDO);

@@ -103,7 +104,7 @@

- (IBAction)onClickAdvancedLink:(id)sender {

if (isSyncDialog_) {

- signin_metrics::LogSigninConfirmHistogramValue(

+ OneClickSigninHelper::LogConfirmHistogramValue(

clickedLearnMore_ ?

signin_metrics::HISTOGRAM_CONFIRM_LEARN_MORE_ADVANCED :

signin_metrics::HISTOGRAM_CONFIRM_ADVANCED);

@@ -122,7 +123,7 @@

- (IBAction)onClickClose:(id)sender {

if (isSyncDialog_) {

- signin_metrics::LogSigninConfirmHistogramValue(

+ OneClickSigninHelper::LogConfirmHistogramValue(

clickedLearnMore_ ?

signin_metrics::HISTOGRAM_CONFIRM_LEARN_MORE_CLOSE :

signin_metrics::HISTOGRAM_CONFIRM_CLOSE);

@@ -210,7 +211,7 @@

delta:delta];

if (isSyncDialog_) {

- signin_metrics::LogSigninConfirmHistogramValue(

+ OneClickSigninHelper::LogConfirmHistogramValue(

signin_metrics::HISTOGRAM_CONFIRM_SHOWN);

}

@@ -286,7 +287,7 @@

if (isSyncDialog_ && !clickedLearnMore_) {

clickedLearnMore_ = YES;

- signin_metrics::LogSigninConfirmHistogramValue(

+ OneClickSigninHelper::LogConfirmHistogramValue(

signin_metrics::HISTOGRAM_CONFIRM_LEARN_MORE);

}

WindowOpenDisposition location = isSyncDialog_ ?