Pass correct initial/user values when requesting power status

Pass correct initial/user values when requesting power status

BUG=121982
TEST=Run chrome/ash on linux. Battery indicator should not be draining. Click on status area. Battery should start draining.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132739

[stevenjb, 2012-04-09 17:09:56]

Not urgent, but would like to get this in ToT soonish for testing, thanks.

[sadrul, 2012-04-10 00:01:34]

http://codereview.chromium.org/9983002/diff/1/ash/system/power/tray_power.cc
File ash/system/power/tray_power.cc (right):

http://codereview.chromium.org/9983002/diff/1/ash/system/power/tray_power.cc#...
ash/system/power/tray_power.cc:190: SystemTrayDelegate::UPDATE_USER);
It probably makes sense to remove the call to RequestStatusUpdate in
GetPowerSupplyStatus, and have an explicit
tray_delegate()->RequestPowerStatusUpdate(void), which will make the call to
RequestStatusUpdate. That way, ash doesn't need to know about the update-type.

http://codereview.chromium.org/9983002/diff/1/ash/system/tray/system_tray_del...
File ash/system/tray/system_tray_delegate.h (right):

http://codereview.chromium.org/9983002/diff/1/ash/system/tray/system_tray_del...
ash/system/tray/system_tray_delegate.h:73: // /chromeos directory.
Looks like the relevant code has already moved into chromeos/

[stevenjb, 2012-04-10 18:02:03]

http://codereview.chromium.org/9983002/diff/1/ash/system/power/tray_power.cc
File ash/system/power/tray_power.cc (right):

http://codereview.chromium.org/9983002/diff/1/ash/system/power/tray_power.cc#...
ash/system/power/tray_power.cc:190: SystemTrayDelegate::UPDATE_USER);
On 2012/04/10 00:01:34, sadrul wrote:
> It probably makes sense to remove the call to RequestStatusUpdate in
> GetPowerSupplyStatus, and have an explicit
> tray_delegate()->RequestPowerStatusUpdate(void), which will make the call to
> RequestStatusUpdate. That way, ash doesn't need to know about the update-type.

That makes sense. Done.

http://codereview.chromium.org/9983002/diff/1/ash/system/tray/system_tray_del...
File ash/system/tray/system_tray_delegate.h (right):

http://codereview.chromium.org/9983002/diff/1/ash/system/tray/system_tray_del...
ash/system/tray/system_tray_delegate.h:73: // /chromeos directory.
On 2012/04/10 00:01:34, sadrul wrote:
> Looks like the relevant code has already moved into chromeos/

Removed.

[stevenjb, 2012-04-11 18:20:53]

ping?

[sadrul, 2012-04-11 18:22:15]

Sorry, this got lost in the mail. LGTM.

[commit-bot: I haz the power, 2012-04-11 18:23:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/9983002/5001

[commit-bot: I haz the power, 2012-04-11 18:23:41]

Presubmit check for 9983002-5001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    ash

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[stevenjb, 2012-04-11 18:28:23]

+sky for OWNERS

[sky, 2012-04-11 20:51:34]

LGTM

http://codereview.chromium.org/9983002/diff/5001/ash/system/power/tray_power.cc
File ash/system/power/tray_power.cc (right):

http://codereview.chromium.org/9983002/diff/5001/ash/system/power/tray_power....
ash/system/power/tray_power.cc:204: 
nit: I don't find this newline helping readability.

[commit-bot: I haz the power, 2012-04-11 21:18:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/9983002/5001

[commit-bot: I haz the power, 2012-04-11 21:40:02]

Try job failure for 9983002-5001 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-04-18 01:39:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/9983002/5001

[commit-bot: I haz the power, 2012-04-18 03:33:14]

Change committed as 132739