Debugger: deduplicate shared function info when setting script break points.

Debugger: deduplicate shared function info when setting script break points.

Also fix Debug.showBreakPoints for multiple break points at the same location.

BUG=v8:3960
LOG=N

Committed: https://crrev.com/73b17a71a22564c0b66d9aa7c00948c748f5b290
Cr-Commit-Position: refs/heads/master@{#27444}

[Yang, 2015-03-25 11:54:46]

yangguo@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Yang, 2015-03-25 11:54:46]

Please take a look.

[Michael Starzinger, 2015-03-25 13:44:08]

Just one main comment about the factory.cc change.

https://codereview.chromium.org/998253005/diff/20001/src/debug.cc
File src/debug.cc (right):

https://codereview.chromium.org/998253005/diff/20001/src/debug.cc#newcode2106
src/debug.cc:2106: SharedFunctionInfo* s = function->shared();
nit: s/s/shared/ here.

https://codereview.chromium.org/998253005/diff/20001/src/factory.cc
File src/factory.cc (right):

https://codereview.chromium.org/998253005/diff/20001/src/factory.cc#newcode1357
src/factory.cc:1357: info->allows_lazy_compilation() &&
!info->optimization_disabled();
Is this additional part of the predicate necessary for correctness? I am not a
big fan of this early checks throughout the code and would like to consolidate
those in compiler.cc as much as possible.

[Yang, 2015-03-25 14:09:42]

I removed the change in factory.cc. As discussed offline, I changed the live
edit tests and filed a bug.

https://codereview.chromium.org/998253005/diff/20001/src/factory.cc
File src/factory.cc (right):

https://codereview.chromium.org/998253005/diff/20001/src/factory.cc#newcode1357
src/factory.cc:1357: info->allows_lazy_compilation() &&
!info->optimization_disabled();
On 2015/03/25 13:44:08, Michael Starzinger wrote:
> Is this additional part of the predicate necessary for correctness? I am not a
> big fan of this early checks throughout the code and would like to consolidate
> those in compiler.cc as much as possible.

Done.

[Michael Starzinger, 2015-03-25 14:13:11]

LGTM (nit still applies).

[Yang, 2015-03-25 14:16:41]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-03-25 14:16:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/998253005/#ps60001 (title:
"fixed nit")

[commit-bot: I haz the power, 2015-03-25 14:17:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/998253005/60001

[commit-bot: I haz the power, 2015-03-25 14:53:45]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-25 14:54:01]

Patchset 4 (id:??) landed as
https://crrev.com/73b17a71a22564c0b66d9aa7c00948c748f5b290
Cr-Commit-Position: refs/heads/master@{#27444}

[Yang, 2015-03-25 15:18:45]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/999273003/ by yangguo@chromium.org.

The reason for reverting is: Code caching failures..