src/compiler.cc - Issue 998253005: Debugger: deduplicate shared function info when setting script break points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler.cc

Issue 998253005: Debugger: deduplicate shared function info when setting script break points. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fixed nit Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler.cc

diff --git a/src/compiler.cc b/src/compiler.cc

index 0bf2c7b6a621ff9a38c3714e992bd3745fe5f528..7b685c939ecdd0df24ae6355da38a329bd46a29e 100644

--- a/src/compiler.cc

+++ b/src/compiler.cc

@@ -1426,7 +1426,7 @@ Handle<SharedFunctionInfo> Compiler::BuildFunctionInfo(

result->set_is_toplevel(false);

RecordFunctionCompilation(Logger::FUNCTION_TAG, &info, result);

- result->set_allows_lazy_compilation(allow_lazy);

+ result->set_allows_lazy_compilation(literal->AllowsLazyCompilation());

result->set_allows_lazy_compilation_without_context(allow_lazy_without_ctx);

// Set the expected number of properties for instances and return

« no previous file with comments | « no previous file | src/debug.cc » ('j') | no next file with comments »