Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: src/compiler.cc

Issue 998253005: Debugger: deduplicate shared function info when setting script break points. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fixed nit Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/debug.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler.h" 5 #include "src/compiler.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "src/ast-numbering.h" 9 #include "src/ast-numbering.h"
10 #include "src/bootstrapper.h" 10 #include "src/bootstrapper.h"
(...skipping 1408 matching lines...) Expand 10 before | Expand all | Expand 10 after
1419 // Create a shared function info object. 1419 // Create a shared function info object.
1420 Handle<SharedFunctionInfo> result = factory->NewSharedFunctionInfo( 1420 Handle<SharedFunctionInfo> result = factory->NewSharedFunctionInfo(
1421 literal->name(), literal->materialized_literal_count(), literal->kind(), 1421 literal->name(), literal->materialized_literal_count(), literal->kind(),
1422 info.code(), scope_info, info.feedback_vector()); 1422 info.code(), scope_info, info.feedback_vector());
1423 1423
1424 SharedFunctionInfo::InitFromFunctionLiteral(result, literal); 1424 SharedFunctionInfo::InitFromFunctionLiteral(result, literal);
1425 result->set_script(*script); 1425 result->set_script(*script);
1426 result->set_is_toplevel(false); 1426 result->set_is_toplevel(false);
1427 1427
1428 RecordFunctionCompilation(Logger::FUNCTION_TAG, &info, result); 1428 RecordFunctionCompilation(Logger::FUNCTION_TAG, &info, result);
1429 result->set_allows_lazy_compilation(allow_lazy); 1429 result->set_allows_lazy_compilation(literal->AllowsLazyCompilation());
1430 result->set_allows_lazy_compilation_without_context(allow_lazy_without_ctx); 1430 result->set_allows_lazy_compilation_without_context(allow_lazy_without_ctx);
1431 1431
1432 // Set the expected number of properties for instances and return 1432 // Set the expected number of properties for instances and return
1433 // the resulting function. 1433 // the resulting function.
1434 SetExpectedNofPropertiesFromEstimate(result, 1434 SetExpectedNofPropertiesFromEstimate(result,
1435 literal->expected_property_count()); 1435 literal->expected_property_count());
1436 live_edit_tracker.RecordFunctionInfo(result, literal, info.zone()); 1436 live_edit_tracker.RecordFunctionInfo(result, literal, info.zone());
1437 return result; 1437 return result;
1438 } 1438 }
1439 1439
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
1575 } 1575 }
1576 1576
1577 1577
1578 #if DEBUG 1578 #if DEBUG
1579 void CompilationInfo::PrintAstForTesting() { 1579 void CompilationInfo::PrintAstForTesting() {
1580 PrintF("--- Source from AST ---\n%s\n", 1580 PrintF("--- Source from AST ---\n%s\n",
1581 PrettyPrinter(isolate(), zone()).PrintProgram(function())); 1581 PrettyPrinter(isolate(), zone()).PrintProgram(function()));
1582 } 1582 }
1583 #endif 1583 #endif
1584 } } // namespace v8::internal 1584 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698