Relanding Add i18n support for Android App Restrictions.

Relanding Add i18n support for Android App Restrictions.

Reason for revert:
Changing the first output of grd file caused build to fail due to a bad depfile. Now depfile depends on a stampfile instead of first output.
Hence this also adds an additional grit roll from r187 to r188.

Effective grit roll from r186:r188

188: Allow depending on stamp for grit files.
187: Add a Policy template writer that generates Android resources which can be exposed through Android's App Restriction Schema.

Original issue's description:
> Revert of Add i18n support for Android App Restrictions. (patchset #7 id:120001 of https://codereview.chromium.org/865573002/)
>
> Reason for revert:
> Broke some GN builds, e.g.:
>
> http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/24483/steps/compile/logs/stdio
> http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/11092/steps/compile/logs/stdio
>
> ninja: Entering directory `/mnt/data/b/build/slave/Linux_GN/build/src/out/Release'
> ninja:error: expected depfile 'gen/chrome/policy_templates.d' to mention 'gen/chrome/app/policy/common/html/am/chrome_policy_list.html', got 'gen/chrome/app/policy/linux/examples/chrome.json'
>
>
> Committed: https://crrev.com/27ee0fa9afe9cb97016e532bd0cecd1b011251b9
> Cr-Commit-Position: refs/heads/master@{#319773}

BUG=450548
Committed: https://crrev.com/7b9eaf967bfa9731f1862fce2b4115a320411722
Cr-Commit-Position: refs/heads/master@{#322366}

[knn, 2015-03-10 11:13:08]

Created Revert of Revert of Add i18n support for Android App Restrictions.

[knn, 2015-03-10 11:28:16]

knn@chromium.org changed reviewers:
+ jochen@chromium.org

[knn, 2015-03-10 11:28:16]

jochen@chromium.org: Please review changes in build/get_landmines.py.

Need to clobber builds as policy_templates.grd has changed.

[bartfab (slow), 2015-03-10 12:54:38]

lgtm

[jochen (gone - plz use gerrit), 2015-03-10 13:08:01]

jochen@chromium.org changed reviewers:
+ thakis@chromium.org

[jochen (gone - plz use gerrit), 2015-03-10 13:08:01]

Nico, is it expected that ninja needs a landmine for grd changes? (The error
message is in this CL's description)

[Nico, 2015-03-10 14:01:39]

As a general guideline, landmines should never be required. They're clutches to
be used when something goes wrong in a way that can't easily be fixed by fixing
build files It's almost never the right thing to land a new change with
known-bad deps (like this one apparently is) and paper over the fact with a
landmine.

[Nico, 2015-03-10 14:02:53]

The

ninja: Entering directory
`/mnt/data/b/build/slave/Linux_GN/build/src/out/Release'
ninja:error: expected depfile 'gen/chrome/policy_templates.d' to mention
'gen/chrome/app/policy/common/html/am/chrome_policy_list.html', got
'gen/chrome/app/policy/linux/examples/chrome.json'


from the bug snippet suggests that gn's grit depfile integration isn't working
well. I'd bring that up with the gn folks and ask them for advice..

[knn, 2015-03-10 14:13:24]

On 2015/03/10 14:02:53, Nico wrote:
> The
> 
> ninja: Entering directory
> `/mnt/data/b/build/slave/Linux_GN/build/src/out/Release'
> ninja:error: expected depfile 'gen/chrome/policy_templates.d' to mention
> 'gen/chrome/app/policy/common/html/am/chrome_policy_list.html', got
> 'gen/chrome/app/policy/linux/examples/chrome.json'
> 
> 
> from the bug snippet suggests that gn's grit depfile integration isn't working
> well. I'd bring that up with the gn folks and ask them for advice..

Ok, Thanks, I'll do that.

[jochen (gone - plz use gerrit), 2015-03-10 14:36:02]

Nico, should this land meanwhile with the landmine?

[Nico, 2015-03-10 14:37:01]

imho no

On Tue, Mar 10, 2015 at 7:36 AM, <jochen@chromium.org> wrote:

> Nico, should this land meanwhile with the landmine?
>
> https://codereview.chromium.org/997523002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2015-03-10 14:38:05]

(but if you're in a rush and want to land this quickly while fixing gn
stuff asynchronously, a workaround is probably to also
rename components/policy/resources/policy_templates.grd in this patch, then
it'll get a different .d file and ninja won't complain that the outputs in
the existing .d file changed)

On Tue, Mar 10, 2015 at 7:36 AM, Nico Weber <thakis@chromium.org> wrote:

> imho no
>
> On Tue, Mar 10, 2015 at 7:36 AM, <jochen@chromium.org> wrote:
>
>> Nico, should this land meanwhile with the landmine?
>>
>> https://codereview.chromium.org/997523002/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[knn, 2015-03-26 12:17:51]

The CQ bit was checked by knn@chromium.org

[knn, 2015-03-26 12:17:51]

The patchset sent to the CQ was uploaded after l-g-t-m from bartfab@chromium.org
Link to the patchset: https://codereview.chromium.org/997523002/#ps170001
(title: "Merge issue 996653002")

[commit-bot: I haz the power, 2015-03-26 12:18:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/997523002/170001

[commit-bot: I haz the power, 2015-03-26 12:21:37]

Committed patchset #4 (id:170001)

[commit-bot: I haz the power, 2015-03-26 12:22:16]

Patchset 4 (id:??) landed as
https://crrev.com/7b9eaf967bfa9731f1862fce2b4115a320411722
Cr-Commit-Position: refs/heads/master@{#322366}