Add i18n support for Android App Restrictions.

Add i18n support for Android App Restrictions.

GYP target policy_templates is now enabled for android as well.
Remove code that generated Policy resources w/o translation for Android.

roll grit 186:187

187: Add a Policy template writer that generates Android resources which can be exposed through Android's App Restriction Schema.

Depends on:
https://codereview.chromium.org/865563002

BUG=450548

[knn, 2015-01-21 11:25:12]

knn@chromium.org changed reviewers:
+ bauerb@chromium.org

[Bernhard Bauer, 2015-01-21 14:23:48]

https://codereview.chromium.org/865573002/diff/1/components/policy.gypi
File components/policy.gypi (left):

https://codereview.chromium.org/865573002/diff/1/components/policy.gypi#oldco...
components/policy.gypi:363: ['OS=="win" or OS=="mac" or OS=="linux"', {
Shouldn't this stay here and just get extended by OS=='android'? There are still
other OS's where we don't need this target (Chrome OS, iOS).

https://codereview.chromium.org/865573002/diff/1/components/policy/resources/...
File components/policy/resources/policy_templates.grd (left):

https://codereview.chromium.org/865573002/diff/1/components/policy/resources/...
components/policy/resources/policy_templates.grd:9: <output
filename="app/policy/linux/examples/chrome.json" type="json" lang="en" />
Where does this go now?

[knn, 2015-01-21 14:42:18]

https://codereview.chromium.org/865573002/diff/1/components/policy.gypi
File components/policy.gypi (left):

https://codereview.chromium.org/865573002/diff/1/components/policy.gypi#oldco...
components/policy.gypi:363: ['OS=="win" or OS=="mac" or OS=="linux"', {
On 2015/01/21 14:23:48, Bernhard Bauer wrote:
> Shouldn't this stay here and just get extended by OS=='android'? There are
still
> other OS's where we don't need this target (Chrome OS, iOS).

Sorry, forgot about iOS. isn't ChromeOs still under OS=linux but with the
chromeos flag?

https://codereview.chromium.org/865573002/diff/1/components/policy/resources/...
File components/policy/resources/policy_templates.grd (left):

https://codereview.chromium.org/865573002/diff/1/components/policy/resources/...
components/policy/resources/policy_templates.grd:9: <output
filename="app/policy/linux/examples/chrome.json" type="json" lang="en" />
On 2015/01/21 14:23:48, Bernhard Bauer wrote:
> Where does this go now?

Inside not android first line. Will update for iOS.

[Bernhard Bauer, 2015-01-21 15:43:27]

https://codereview.chromium.org/865573002/diff/1/components/policy.gypi
File components/policy.gypi (left):

https://codereview.chromium.org/865573002/diff/1/components/policy.gypi#oldco...
components/policy.gypi:363: ['OS=="win" or OS=="mac" or OS=="linux"', {
On 2015/01/21 14:42:18, knn wrote:
> On 2015/01/21 14:23:48, Bernhard Bauer wrote:
> > Shouldn't this stay here and just get extended by OS=='android'? There are
> still
> > other OS's where we don't need this target (Chrome OS, iOS).
> 
> Sorry, forgot about iOS. isn't ChromeOs still under OS=linux but with the
> chromeos flag?

That's true. We probably don't need the templates for Chrome OS though, because
that only supports cloud policy.

https://codereview.chromium.org/865573002/diff/1/components/policy/resources/...
File components/policy/resources/policy_templates.grd (left):

https://codereview.chromium.org/865573002/diff/1/components/policy/resources/...
components/policy/resources/policy_templates.grd:9: <output
filename="app/policy/linux/examples/chrome.json" type="json" lang="en" />
On 2015/01/21 14:42:18, knn wrote:
> On 2015/01/21 14:23:48, Bernhard Bauer wrote:
> > Where does this go now?
> 
> Inside not android first line. Will update for iOS.

I would probably put this into an is_linux block.

[knn, 2015-01-21 16:39:30]

knn@chromium.org changed reviewers:
+ bartfab@chromium.org

[knn, 2015-01-21 16:39:31]

Done PTAL

+bartfab@ for owners review.
Adding you since you reviewed my previous change and have more context.

https://codereview.chromium.org/865573002/diff/1/components/policy.gypi
File components/policy.gypi (left):

https://codereview.chromium.org/865573002/diff/1/components/policy.gypi#oldco...
components/policy.gypi:363: ['OS=="win" or OS=="mac" or OS=="linux"', {
On 2015/01/21 15:43:27, Bernhard Bauer wrote:
> On 2015/01/21 14:42:18, knn wrote:
> > On 2015/01/21 14:23:48, Bernhard Bauer wrote:
> > > Shouldn't this stay here and just get extended by OS=='android'? There are
> > still
> > > other OS's where we don't need this target (Chrome OS, iOS).
> > 
> > Sorry, forgot about iOS. isn't ChromeOs still under OS=linux but with the
> > chromeos flag?
> 
> That's true. We probably don't need the templates for Chrome OS though,
because
> that only supports cloud policy.

Done.

https://codereview.chromium.org/865573002/diff/1/components/policy/resources/...
File components/policy/resources/policy_templates.grd (left):

https://codereview.chromium.org/865573002/diff/1/components/policy/resources/...
components/policy/resources/policy_templates.grd:9: <output
filename="app/policy/linux/examples/chrome.json" type="json" lang="en" />
On 2015/01/21 15:43:27, Bernhard Bauer wrote:
> On 2015/01/21 14:42:18, knn wrote:
> > On 2015/01/21 14:23:48, Bernhard Bauer wrote:
> > > Where does this go now?
> > 
> > Inside not android first line. Will update for iOS.
> 
> I would probably put this into an is_linux block.

Done.

[Bernhard Bauer, 2015-01-21 17:06:16]

LGTM

https://codereview.chromium.org/865573002/diff/20001/components/policy/resour...
File components/policy/resources/policy_templates.grd (right):

https://codereview.chromium.org/865573002/diff/20001/components/policy/resour...
components/policy/resources/policy_templates.grd:126: <if expr="not is_android">
Should we enable this on Android as well, just for the sake of completeness?

[bartfab (slow), 2015-01-26 09:58:00]

https://codereview.chromium.org/865573002/diff/20001/components/policy.gypi
File components/policy.gypi (right):

https://codereview.chromium.org/865573002/diff/20001/components/policy.gypi#n...
components/policy.gypi:357: ['OS!="ios" and chromeos==0', {
Why do you exclude policy_templates on Chrome OS?

https://codereview.chromium.org/865573002/diff/20001/components/policy/resour...
File components/policy/resources/policy_templates.grd (right):

https://codereview.chromium.org/865573002/diff/20001/components/policy/resour...
components/policy/resources/policy_templates.grd:126: <if expr="not is_android">
Nit: Why the blank lines before and after this?

[knn, 2015-01-27 11:27:14]

Adding Chrome OS back in policy_templates as the documentation pages seem
relevant even if they are only configured in the cloud.

https://codereview.chromium.org/865573002/diff/20001/components/policy.gypi
File components/policy.gypi (right):

https://codereview.chromium.org/865573002/diff/20001/components/policy.gypi#n...
components/policy.gypi:357: ['OS!="ios" and chromeos==0', {
On 2015/01/26 09:57:59, bartfab wrote:
> Why do you exclude policy_templates on Chrome OS?

As Bernhard pointed out to me, Chrome OS uses Cloud Policy so the templates are
not required.
I am adding this back as the documentation pages generated does seem relevant to
Chrome OS as well.
So tldr=reverting that.

https://codereview.chromium.org/865573002/diff/20001/components/policy/resour...
File components/policy/resources/policy_templates.grd (right):

https://codereview.chromium.org/865573002/diff/20001/components/policy/resour...
components/policy/resources/policy_templates.grd:126: <if expr="not is_android">
On 2015/01/26 09:58:00, bartfab wrote:
> Nit: Why the blank lines before and after this?

There are no blank lines, Rietveld shows blank lines because of the comments.

https://codereview.chromium.org/865573002/diff/20001/components/policy/resour...
components/policy/resources/policy_templates.grd:126: <if expr="not is_android">
On 2015/01/21 17:06:16, Bernhard Bauer wrote:
> Should we enable this on Android as well, just for the sake of completeness?

Done.

[Bernhard Bauer, 2015-01-27 12:05:43]

https://codereview.chromium.org/865573002/diff/20001/components/policy.gypi
File components/policy.gypi (right):

https://codereview.chromium.org/865573002/diff/20001/components/policy.gypi#n...
components/policy.gypi:357: ['OS!="ios" and chromeos==0', {
On 2015/01/27 11:27:13, knn wrote:
> On 2015/01/26 09:57:59, bartfab wrote:
> > Why do you exclude policy_templates on Chrome OS?
> 
> As Bernhard pointed out to me, Chrome OS uses Cloud Policy so the templates
are
> not required.
> I am adding this back as the documentation pages generated does seem relevant
to
> Chrome OS as well.
> So tldr=reverting that.

Really, the target should probably be called localized_policy_...something :)

[bartfab (slow), 2015-01-27 12:10:00]

https://codereview.chromium.org/865573002/diff/20001/components/policy.gypi
File components/policy.gypi (right):

https://codereview.chromium.org/865573002/diff/20001/components/policy.gypi#n...
components/policy.gypi:357: ['OS!="ios" and chromeos==0', {
On 2015/01/27 12:05:43, Bernhard Bauer wrote:
> On 2015/01/27 11:27:13, knn wrote:
> > On 2015/01/26 09:57:59, bartfab wrote:
> > > Why do you exclude policy_templates on Chrome OS?
> > 
> > As Bernhard pointed out to me, Chrome OS uses Cloud Policy so the templates
> are
> > not required.
> > I am adding this back as the documentation pages generated does seem
relevant
> to
> > Chrome OS as well.
> > So tldr=reverting that.
> 
> Really, the target should probably be called localized_policy_...something :)

I am actually not sure what exactly this target generates. The documentation
pages are somewhat useful. The protos are critical. Since this target does not
list any outputs, it is hard to tell whether it is responsible for generating
the protos as well.

[bartfab (slow), 2015-01-27 12:12:55]

lgtm

[knn, 2015-01-27 12:18:36]

https://codereview.chromium.org/865573002/diff/20001/components/policy.gypi
File components/policy.gypi (right):

https://codereview.chromium.org/865573002/diff/20001/components/policy.gypi#n...
components/policy.gypi:357: ['OS!="ios" and chromeos==0', {
On 2015/01/27 12:10:00, bartfab wrote:
> On 2015/01/27 12:05:43, Bernhard Bauer wrote:
> > On 2015/01/27 11:27:13, knn wrote:
> > > On 2015/01/26 09:57:59, bartfab wrote:
> > > > Why do you exclude policy_templates on Chrome OS?
> > > 
> > > As Bernhard pointed out to me, Chrome OS uses Cloud Policy so the
templates
> > are
> > > not required.
> > > I am adding this back as the documentation pages generated does seem
> relevant
> > to
> > > Chrome OS as well.
> > > So tldr=reverting that.
> > 
> > Really, the target should probably be called localized_policy_...something
:)
> 
> I am actually not sure what exactly this target generates. The documentation
> pages are somewhat useful. The protos are critical. Since this target does not
> list any outputs, it is hard to tell whether it is responsible for generating
> the protos as well.

Yeah we could rename this generate_localized_policy_templates.
The protos are generated in generate_policy_source.

[Bernhard Bauer, 2015-01-27 12:19:59]

https://codereview.chromium.org/865573002/diff/20001/components/policy.gypi
File components/policy.gypi (right):

https://codereview.chromium.org/865573002/diff/20001/components/policy.gypi#n...
components/policy.gypi:357: ['OS!="ios" and chromeos==0', {
On 2015/01/27 12:10:00, bartfab wrote:
> On 2015/01/27 12:05:43, Bernhard Bauer wrote:
> > On 2015/01/27 11:27:13, knn wrote:
> > > On 2015/01/26 09:57:59, bartfab wrote:
> > > > Why do you exclude policy_templates on Chrome OS?
> > > 
> > > As Bernhard pointed out to me, Chrome OS uses Cloud Policy so the
templates
> > are
> > > not required.
> > > I am adding this back as the documentation pages generated does seem
> relevant
> > to
> > > Chrome OS as well.
> > > So tldr=reverting that.
> > 
> > Really, the target should probably be called localized_policy_...something
:)
> 
> I am actually not sure what exactly this target generates. The documentation
> pages are somewhat useful. The protos are critical. Since this target does not
> list any outputs, it is hard to tell whether it is responsible for generating
> the protos as well.

The protos are generated by the cloud_policy_code_generate target, which runs
`generate_policy_source.py --cloud-policy-protobuf`. This target only builds
stuff that is localized.

[bartfab (slow), 2015-01-27 15:50:36]

On 2015/01/27 12:19:59, Bernhard Bauer wrote:
> https://codereview.chromium.org/865573002/diff/20001/components/policy.gypi
> File components/policy.gypi (right):
> 
>
https://codereview.chromium.org/865573002/diff/20001/components/policy.gypi#n...
> components/policy.gypi:357: ['OS!="ios" and chromeos==0', {
> On 2015/01/27 12:10:00, bartfab wrote:
> > On 2015/01/27 12:05:43, Bernhard Bauer wrote:
> > > On 2015/01/27 11:27:13, knn wrote:
> > > > On 2015/01/26 09:57:59, bartfab wrote:
> > > > > Why do you exclude policy_templates on Chrome OS?
> > > > 
> > > > As Bernhard pointed out to me, Chrome OS uses Cloud Policy so the
> templates
> > > are
> > > > not required.
> > > > I am adding this back as the documentation pages generated does seem
> > relevant
> > > to
> > > > Chrome OS as well.
> > > > So tldr=reverting that.
> > > 
> > > Really, the target should probably be called localized_policy_...something
> :)
> > 
> > I am actually not sure what exactly this target generates. The documentation
> > pages are somewhat useful. The protos are critical. Since this target does
not
> > list any outputs, it is hard to tell whether it is responsible for
generating
> > the protos as well.
> 
> The protos are generated by the cloud_policy_code_generate target, which runs
> `generate_policy_source.py --cloud-policy-protobuf`. This target only builds
> stuff that is localized.

The only documentation of Chrome OS policies we publish is this:

http://www.chromium.org/administrators/policy-list-3

This must be built by some platform-agnostic target as it documents policies
across all platforms. As long as we continue providing this, we can turn off all
other documentation building on Chrome OS. It will not be used anywhere anyway.

[knn, 2015-03-09 22:43:05]

The CQ bit was checked by knn@chromium.org

[knn, 2015-03-09 22:43:06]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
bartfab@chromium.org
Link to the patchset: https://codereview.chromium.org/865573002/#ps120001
(title: "Grit roll")

[commit-bot: I haz the power, 2015-03-09 22:44:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/865573002/120001

[commit-bot: I haz the power, 2015-03-09 23:11:33]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-03-09 23:12:35]

Patchset 7 (id:??) landed as
https://crrev.com/cd9f7d3afef0d0d4054318e9999aee879eaf26e1
Cr-Commit-Position: refs/heads/master@{#319758}

[dgrogan, 2015-03-09 23:46:05]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/992853002/ by dgrogan@chromium.org.

The reason for reverting is: Broke some GN builds, e.g.:

http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/24483/s...
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

ninja: Entering directory
`/mnt/data/b/build/slave/Linux_GN/build/src/out/Release'
ninja:error: expected depfile 'gen/chrome/policy_templates.d' to mention
'gen/chrome/app/policy/common/html/am/chrome_policy_list.html', got
'gen/chrome/app/policy/linux/examples/chrome.json'
.

[knn, 2015-03-10 11:03:27]

knn@chromium.org changed reviewers:
+ jochen@chromium.org

[knn, 2015-03-10 11:03:28]

jochen@chromium.org: Please review changes in 
build/get_landmines.py

Need to clobber builds as policy_templates.grd has changed.

[knn, 2015-03-10 11:31:19]

On 2015/03/10 11:03:28, knn wrote:
> mailto:jochen@chromium.org: Please review changes in 
> build/get_landmines.py
> 
> Need to clobber builds as policy_templates.grd has changed.

Created a new issue here https://codereview.chromium.org/997523002/ and closing
this.