Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 997353005: Start fresh on swizzles (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 9 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Start fresh on swizzles This removes all the existing Sk4x swizzles and adds badc(), which is both fast on all implementations and currently useful. BUG=skia: Committed: https://skia.googlesource.com/skia/+/2e220fb9ece0fcce8a4c4a3838bbe64d7492b139

Patch Set 1 #

Patch Set 2 : badc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -70 lines) Patch
M src/core/Sk4x.h View 1 1 chunk +2 lines, -10 lines 0 comments Download
M src/opts/Sk4x_neon.h View 1 2 chunks +2 lines, -40 lines 0 comments Download
M src/opts/Sk4x_none.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/opts/Sk4x_sse.h View 1 1 chunk +1 line, -11 lines 0 comments Download
M tests/Sk4xTest.cpp View 1 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtklein_C
5 years, 9 months ago (2015-03-23 19:53:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997353005/20001
5 years, 9 months ago (2015-03-23 19:54:35 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-23 19:54:35 UTC) #5
reed1
lgtm
5 years, 9 months ago (2015-03-23 20:17:05 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 20:19:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2e220fb9ece0fcce8a4c4a3838bbe64d7492b139

Powered by Google App Engine
This is Rietveld 408576698