Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: src/core/Sk4x.h

Issue 997353005: Start fresh on swizzles (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: badc Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/opts/Sk4x_neon.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/Sk4x.h
diff --git a/src/core/Sk4x.h b/src/core/Sk4x.h
index ebbc20bdcb82236269b1b08e86e5722ce1a01cfa..324ecc4bd8ce5eb342dbce1b9b3cf90178d2de19 100644
--- a/src/core/Sk4x.h
+++ b/src/core/Sk4x.h
@@ -92,16 +92,8 @@ public:
static Sk4x Min(const Sk4x& a, const Sk4x& b);
static Sk4x Max(const Sk4x& a, const Sk4x& b);
- // Swizzles follow OpenCL xyzw convention.
- Sk4x zwxy() const;
-
- // When there's a second argument, it's abcd.
- static Sk4x XYAB(const Sk4x& xyzw, const Sk4x& abcd);
- static Sk4x ZWCD(const Sk4x& xyzw, const Sk4x& abcd);
-
- // TODO: these are particularly efficient in SSE. Useful? Also efficient in NEON?
- // static Sk4x XAYB(const Sk4x& xyzw, const Sk4x& abcd);
- // static Sk4x ZCWD(const Sk4x& xyzw, const Sk4x& abcd);
+ // Swizzles, where this == abcd.
+ Sk4x badc() const;
private:
// It's handy to have Sk4f and Sk4i be mutual friends.
« no previous file with comments | « no previous file | src/opts/Sk4x_neon.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698