Issue 99623012: Make calls to AtomicString(const String&) explicit in testing/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99623012: Make calls to AtomicString(const String&) explicit in testing/ (Closed)

Created:
6 years, 11 months ago by Inactive

Modified:
6 years, 11 months ago

Reviewers:
eseidel

CC:
blink-reviews, dglazkov

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Make calls to AtomicString(const String&) explicit in testing/ Make calls to AtomicString(const String&) explicit in testing/ and avoid useless conversions from String to AtomicString when possible. This is one step towards making the AtomicString(const String&) constructor explicit. This CL takes care only of the testing/ part so that it is more easily reviewable. R=eseidel BUG=323739 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164404

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -26 lines)			Patch
M	Source/core/testing/InternalSettings.h	View	1 chunk	+7 lines, -7 lines	0 comments	Download
M	Source/core/testing/InternalSettings.cpp	View	7 chunks	+7 lines, -7 lines	0 comments	Download
M	Source/core/testing/Internals.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	Source/core/testing/Internals.cpp	View	4 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

eseidel

lgtm dimitri has talked about moving font family settings off onto their own object btw.

6 years, 11 months ago (2013-12-31 22:01:15 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/99623012/1

6 years, 11 months ago (2013-12-31 22:01:29 UTC) #3

Message was sent while issue was closed.

Change committed as 164404

Expand Messages | Collapse Messages