Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11312)

Unified Diff: Source/core/testing/Internals.cpp

Issue 99623012: Make calls to AtomicString(const String&) explicit in testing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/testing/Internals.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/testing/Internals.cpp
diff --git a/Source/core/testing/Internals.cpp b/Source/core/testing/Internals.cpp
index 815d0704327cc786d37921cbd6c8b59a35c2f4e1..7adaee26e2c4440694fcf566189701fdefac53da 100644
--- a/Source/core/testing/Internals.cpp
+++ b/Source/core/testing/Internals.cpp
@@ -380,7 +380,7 @@ Node* Internals::parentTreeScope(Node* node, ExceptionState& exceptionState)
return parentTreeScope ? parentTreeScope->rootNode() : 0;
}
-bool Internals::hasSelectorForIdInShadow(Element* host, const String& idValue, ExceptionState& exceptionState)
+bool Internals::hasSelectorForIdInShadow(Element* host, const AtomicString& idValue, ExceptionState& exceptionState)
{
if (!host || !host->shadow()) {
exceptionState.throwUninformativeAndGenericDOMException(InvalidAccessError);
@@ -390,7 +390,7 @@ bool Internals::hasSelectorForIdInShadow(Element* host, const String& idValue, E
return host->shadow()->ensureSelectFeatureSet().hasSelectorForId(idValue);
}
-bool Internals::hasSelectorForClassInShadow(Element* host, const String& className, ExceptionState& exceptionState)
+bool Internals::hasSelectorForClassInShadow(Element* host, const AtomicString& className, ExceptionState& exceptionState)
{
if (!host || !host->shadow()) {
exceptionState.throwUninformativeAndGenericDOMException(InvalidAccessError);
@@ -400,7 +400,7 @@ bool Internals::hasSelectorForClassInShadow(Element* host, const String& classNa
return host->shadow()->ensureSelectFeatureSet().hasSelectorForClass(className);
}
-bool Internals::hasSelectorForAttributeInShadow(Element* host, const String& attributeName, ExceptionState& exceptionState)
+bool Internals::hasSelectorForAttributeInShadow(Element* host, const AtomicString& attributeName, ExceptionState& exceptionState)
{
if (!host || !host->shadow()) {
exceptionState.throwUninformativeAndGenericDOMException(InvalidAccessError);
@@ -678,17 +678,17 @@ String Internals::shadowRootType(const Node* root, ExceptionState& exceptionStat
}
}
-String Internals::shadowPseudoId(Element* element, ExceptionState& exceptionState)
+const AtomicString& Internals::shadowPseudoId(Element* element, ExceptionState& exceptionState)
{
if (!element) {
exceptionState.throwUninformativeAndGenericDOMException(InvalidAccessError);
- return String();
+ return nullAtom;
}
- return element->shadowPseudoId().string();
+ return element->shadowPseudoId();
}
-void Internals::setShadowPseudoId(Element* element, const String& id, ExceptionState& exceptionState)
+void Internals::setShadowPseudoId(Element* element, const AtomicString& id, ExceptionState& exceptionState)
{
if (!element) {
exceptionState.throwUninformativeAndGenericDOMException(InvalidAccessError);
« no previous file with comments | « Source/core/testing/Internals.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698