Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1826)

Unified Diff: Source/core/testing/Internals.h

Issue 99623012: Make calls to AtomicString(const String&) explicit in testing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/testing/InternalSettings.cpp ('k') | Source/core/testing/Internals.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/testing/Internals.h
diff --git a/Source/core/testing/Internals.h b/Source/core/testing/Internals.h
index 3b2a762bba9e43ef93a0c6152780fa03a838dcc4..0d5287629083ed0d1a180918493f86cb25cef0b5 100644
--- a/Source/core/testing/Internals.h
+++ b/Source/core/testing/Internals.h
@@ -102,8 +102,8 @@ public:
bool hasShadowInsertionPoint(const Node*, ExceptionState&) const;
bool hasContentElement(const Node*, ExceptionState&) const;
size_t countElementShadow(const Node*, ExceptionState&) const;
- String shadowPseudoId(Element*, ExceptionState&);
- void setShadowPseudoId(Element*, const String&, ExceptionState&);
+ const AtomicString& shadowPseudoId(Element*, ExceptionState&);
+ void setShadowPseudoId(Element*, const AtomicString&, ExceptionState&);
// CSS Animation / Transition testing.
unsigned numberOfActiveAnimations() const;
@@ -113,9 +113,9 @@ public:
bool isValidContentSelect(Element* insertionPoint, ExceptionState&);
Node* treeScopeRootNode(Node*, ExceptionState&);
Node* parentTreeScope(Node*, ExceptionState&);
- bool hasSelectorForIdInShadow(Element* host, const String& idValue, ExceptionState&);
- bool hasSelectorForClassInShadow(Element* host, const String& className, ExceptionState&);
- bool hasSelectorForAttributeInShadow(Element* host, const String& attributeName, ExceptionState&);
+ bool hasSelectorForIdInShadow(Element* host, const AtomicString& idValue, ExceptionState&);
+ bool hasSelectorForClassInShadow(Element* host, const AtomicString& className, ExceptionState&);
+ bool hasSelectorForAttributeInShadow(Element* host, const AtomicString& attributeName, ExceptionState&);
bool hasSelectorForPseudoClassInShadow(Element* host, const String& pseudoClass, ExceptionState&);
unsigned short compareTreeScopePosition(const Node*, const Node*, ExceptionState&) const;
« no previous file with comments | « Source/core/testing/InternalSettings.cpp ('k') | Source/core/testing/Internals.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698