tools/gn: fix escaping of backslashes

tools/gn: fix escaping of backslashes

BUG=470217
Committed: https://crrev.com/4bf46ca929d17910fcf66cc25e886b986845ca59
Cr-Commit-Position: refs/heads/master@{#323161}

[mdempsky, 2015-03-24 21:11:21]

mdempsky@chromium.org changed reviewers:
+ brettw@chromium.org

[mdempsky, 2015-03-24 21:14:56]

https://codereview.chromium.org/995393005/diff/1/tools/gn/value_unittest.cc
File tools/gn/value_unittest.cc (right):

https://codereview.chromium.org/995393005/diff/1/tools/gn/value_unittest.cc#n...
tools/gn/value_unittest.cc:16: EXPECT_EQ("\"\\foo\\\\\\bar\\\\\"",
strval2.ToString(true));
Without the corresponding value.cc change, this tests fails like so:

../../tools/gn/value_unittest.cc:16: Failure
Value of: strval2.ToString(true)
  Actual: "\"\\foo\\\\bar\\\""
Expected: "\"\\foo\\\\\\bar\\\\\""

[mdempsky, 2015-03-30 20:09:37]

Ping?

[brettw, 2015-03-31 23:01:51]

LGTM with clarification

https://codereview.chromium.org/995393005/diff/1/tools/gn/value.cc
File tools/gn/value.cc (right):

https://codereview.chromium.org/995393005/diff/1/tools/gn/value.cc#newcode128
tools/gn/value.cc:128: bool escaped = false;
The goal of tracking this should be documented, it took me quite a while to
realize you're trying to avoid unnecessarily escaping backslashes.

[mdempsky, 2015-03-31 23:14:48]

https://codereview.chromium.org/995393005/diff/1/tools/gn/value.cc
File tools/gn/value.cc (right):

https://codereview.chromium.org/995393005/diff/1/tools/gn/value.cc#newcode128
tools/gn/value.cc:128: bool escaped = false;
On 2015/03/31 23:01:51, brettw wrote:
> The goal of tracking this should be documented, it took me quite a while to
> realize you're trying to avoid unnecessarily escaping backslashes.

Done, PTAL.

[mdempsky, 2015-04-01 00:32:00]

The CQ bit was checked by mdempsky@chromium.org

[mdempsky, 2015-04-01 00:32:00]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/995393005/#ps40001 (title:
"typo")

[commit-bot: I haz the power, 2015-04-01 00:32:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/995393005/40001

[commit-bot: I haz the power, 2015-04-01 01:17:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-01 01:18:37]

Patchset 3 (id:??) landed as
https://crrev.com/4bf46ca929d17910fcf66cc25e886b986845ca59
Cr-Commit-Position: refs/heads/master@{#323161}

[raymes, 2015-04-01 02:09:39]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1049963002/ by raymes@chromium.org.

The reason for reverting is: Speculatively reverting because of:
http://build.chromium.org/p/chromium.win/buildstatus?builder=Win8%20GN%20%28d...

ERROR at //third_party/WebKit/Source/bindings/scripts/scripts.gni:198:5: Unable
to write file.
    write_file(idl_files_list, rebase_path(invoker.sources, root_build_dir)).