tools/gn: fix escaping of backslashes

tools/gn/value.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/gn/value.h"
 
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "tools/gn/scope.h"
 
@@ skipping 106 matching lines @@
 std::string Value::ToString(bool quote_string) const {
   switch (type_) {
     case NONE:
       return "<void>";
     case BOOLEAN:
       return boolean_value_ ? "true" : "false";
     case INTEGER:
       return base::Int64ToString(int_value_);
     case STRING:
       if (quote_string) {
-        std::string escaped = string_value_;
-        // First escape all special uses of a backslash.
-        ReplaceSubstringsAfterOffset(&escaped, 0, "\\$", "\\\\$");
-        ReplaceSubstringsAfterOffset(&escaped, 0, "\\\"", "\\\\\"");
-
-        // Now escape special chars.
-        ReplaceSubstringsAfterOffset(&escaped, 0, "$", "\\$");
-        ReplaceSubstringsAfterOffset(&escaped, 0, "\"", "\\\"");
-        return "\"" + escaped + "\"";
+        std::string result = "\"";
+        bool escaped = false;

[brettw, 2015/03/31 23:01:51]

The goal of tracking this should be documented, it took me quite a while to
realize you're trying to avoid unnecessarily escaping backslashes.

[mdempsky, 2015/03/31 23:14:47]

Done, PTAL.

+        for (char ch : string_value_) {
+          if (escaped && (ch == '$' || ch == '"' || ch == '\\'))
+            result += '\\';
+          if (ch == '$' || ch == '"')
+            result += '\\';
+          result += ch;
+          escaped = (ch == '\\');
+        }
+        if (escaped)
+          result += '\\';
+        result += '"';
+        return result;
       }
       return string_value_;
     case LIST: {
       std::string result = "[";
       for (size_t i = 0; i < list_value_.size(); i++) {
         if (i > 0)
           result += ", ";
         result += list_value_[i].ToString(true);
       }
       result.push_back(']');
@@ skipping 54 matching lines @@
       // iteration code.
       return false;
     default:
       return false;
   }
 }
 
 bool Value::operator!=(const Value& other) const {
   return !operator==(other);
 }