Issue 994553003: Ensure that sky Nodes are in the document when didMount() is fired. Refactor FixedHeightScrollable …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 994553003: Ensure that sky Nodes are in the document when didMount() is fired. Refactor FixedHeightScrollable … (Closed)

Created:
5 years, 9 months ago by rafaelw

Modified:
5 years, 9 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Ensure that sky Nodes are in the document when didMount() is fired. Refactor FixedHeightScrollable to inspect heights rather than having the passed in BUG= R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e00bfbb3180cc35a504340ad8d373139f2825de9

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -21 lines)			Patch
M	sky/examples/fn/widgets/fixedheightscrollable.dart	View	1	3 chunks	+37 lines, -18 lines	0 comments	Download
M	sky/examples/stocks-fn/stocklist.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/examples/stocks-fn/stockrow.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/framework/fn.dart	View		2 chunks	+1 line, -1 line	0 comments	Download

Total messages: 3 (1 generated)

rafaelw

5 years, 9 months ago (2015-03-09 19:39:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
e00bfbb3180cc35a504340ad8d373139f2825de9 (presubmit successful).