sky/examples/stocks-fn/stocklist.dart - Issue 994553003: Ensure that sky Nodes are in the document when didMount() is fired. Refactor FixedHeightScrollable …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/examples/stocks-fn/stocklist.dart

Issue 994553003: Ensure that sky Nodes are in the document when didMount() is fired. Refactor FixedHeightScrollable … (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: typo Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/examples/stocks-fn/stocklist.dart

diff --git a/sky/examples/stocks-fn/stocklist.dart b/sky/examples/stocks-fn/stocklist.dart

index 187eb68207410fef4552079febf403fadd2bb251..c4ac95fd4b2421b00054a7b52209c88f2f6cb052 100644

--- a/sky/examples/stocks-fn/stocklist.dart

+++ b/sky/examples/stocks-fn/stocklist.dart

@@ -7,7 +7,7 @@ class Stocklist extends FixedHeightScrollable {

Stocklist({

Object key,

this.stocks

- }) : super(key: key, itemHeight: 80.0, height: 800.0, minOffset: 0.0);

+ }) : super(key: key, minOffset: 0.0);

List<Node> renderItems(int start, int count) {

var items = [];

« no previous file with comments | « sky/examples/fn/widgets/fixedheightscrollable.dart ('k') | sky/examples/stocks-fn/stockrow.dart » ('j') | no next file with comments »