Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Unified Diff: sky/framework/fn.dart

Issue 994553003: Ensure that sky Nodes are in the document when didMount() is fired. Refactor FixedHeightScrollable … (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: typo Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/examples/stocks-fn/stockrow.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/framework/fn.dart
diff --git a/sky/framework/fn.dart b/sky/framework/fn.dart
index c921a4c2f48fbfb51bada7d6b85d545cf2d76346..380dc52ebf9a37f6ea68ae70cf97700745b7e5dc 100644
--- a/sky/framework/fn.dart
+++ b/sky/framework/fn.dart
@@ -247,6 +247,7 @@ abstract class Element extends Node {
// print("...no oldElement, initial render");
_root = sky.document.createElement(_tagName);
+ _parentInsertBefore(host, _root, insertBefore);
_syncNode();
for (var child in _children) {
@@ -254,7 +255,6 @@ abstract class Element extends Node {
assert(child._root is sky.Node);
}
- _parentInsertBefore(host, _root, insertBefore);
return false;
}
« no previous file with comments | « sky/examples/stocks-fn/stockrow.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698