Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 992853002: Revert of Add i18n support for Android App Restrictions. (Closed)

Created:
5 years, 9 months ago by dgrogan
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add i18n support for Android App Restrictions. (patchset #7 id:120001 of https://codereview.chromium.org/865573002/) Reason for revert: Broke some GN builds, e.g.: http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/24483/steps/compile/logs/stdio http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/11092/steps/compile/logs/stdio ninja: Entering directory `/mnt/data/b/build/slave/Linux_GN/build/src/out/Release' ninja:error: expected depfile 'gen/chrome/policy_templates.d' to mention 'gen/chrome/app/policy/common/html/am/chrome_policy_list.html', got 'gen/chrome/app/policy/linux/examples/chrome.json' Original issue's description: > Add i18n support for Android App Restrictions. > > GYP target policy_templates is now enabled for android as well. > Remove code that generated Policy resources w/o translation for Android. > > roll grit 186:187 > > 187: Add a Policy template writer that generates Android resources which can be exposed through Android's App Restriction Schema. > > Depends on: > https://codereview.chromium.org/865563002 > > BUG=450548 > > Committed: https://crrev.com/cd9f7d3afef0d0d4054318e9999aee879eaf26e1 > Cr-Commit-Position: refs/heads/master@{#319758} TBR=bauerb@chromium.org,bartfab@chromium.org,knn@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=450548 Committed: https://crrev.com/27ee0fa9afe9cb97016e532bd0cecd1b011251b9 Cr-Commit-Position: refs/heads/master@{#319773}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -139 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/policy.gypi View 6 chunks +8 lines, -2 lines 0 comments Download
M components/policy/BUILD.gn View 4 chunks +18 lines, -6 lines 0 comments Download
M components/policy/resources/policy_templates.grd View 3 chunks +59 lines, -114 lines 0 comments Download
M components/policy/resources/policy_templates.json View 1 chunk +0 lines, -4 lines 0 comments Download
M components/policy/tools/generate_policy_source.py View 7 chunks +68 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dgrogan
Created Revert of Add i18n support for Android App Restrictions.
5 years, 9 months ago (2015-03-09 23:46:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/992853002/1
5 years, 9 months ago (2015-03-09 23:46:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 23:48:09 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/27ee0fa9afe9cb97016e532bd0cecd1b011251b9 Cr-Commit-Position: refs/heads/master@{#319773}
5 years, 9 months ago (2015-03-09 23:48:51 UTC) #4
knn
5 years, 9 months ago (2015-03-10 11:13:07 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/997523002/ by knn@chromium.org.

The reason for reverting is: Relanding with a landmine..

Powered by Google App Engine
This is Rietveld 408576698