Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 992613005: Revert of Test dead code. (Closed)

Created:
5 years, 9 months ago by dgrogan
Modified:
5 years, 9 months ago
Reviewers:
Bence, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Test dead code. (patchset #4 id:60001 of https://codereview.chromium.org/988733003/) Reason for revert: Broke "compile" on "iOS_Device". http://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/26659/steps/compile/logs/stdio Undefined symbols for architecture armv7: "net::SpdyPriorityIR::SpdyPriorityIR(unsigned int, unsigned int, unsigned char, bool)", referenced from: net::SpdyFramerTest_CreatePriority_Test::TestBody() in spdy_framer_test.o net::SpdyFramerTest_ReadPriority_Test::TestBody() in spdy_framer_test.o ld: symbol(s) not found for architecture armv7 clang:error: linker command failed with exit code 1 (use -v to see invocation) Original issue's description: > Test dead code. > > Test a log method that could be helpful for debugging. Also inline SpdyPriorityIR constructors for code convergence. > > This CL lands server change 87053738 by birenroy. > > BUG= > > Committed: https://crrev.com/e44eb0a35c11f8ff743873f5f382b5d5c5353325 > Cr-Commit-Position: refs/heads/master@{#319724} TBR=rch@chromium.org,bnc@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/2136db0ac1af67ab3981249a2c15c2dee8e851d2 Cr-Commit-Position: refs/heads/master@{#319735}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -34 lines) Patch
M net/spdy/spdy_framer_test.cc View 2 chunks +7 lines, -14 lines 0 comments Download
M net/spdy/spdy_headers_block_parser_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/spdy/spdy_priority_tree_test.cc View 3 chunks +0 lines, -8 lines 0 comments Download
M net/spdy/spdy_protocol.h View 1 chunk +2 lines, -10 lines 0 comments Download
M net/spdy/spdy_protocol.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dgrogan
Created Revert of Test dead code.
5 years, 9 months ago (2015-03-09 21:22:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/992613005/1
5 years, 9 months ago (2015-03-09 21:23:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 21:24:18 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2136db0ac1af67ab3981249a2c15c2dee8e851d2 Cr-Commit-Position: refs/heads/master@{#319735}
5 years, 9 months ago (2015-03-09 21:25:08 UTC) #4
Bence
5 years, 9 months ago (2015-03-10 15:35:45 UTC) #5
Message was sent while issue was closed.
On 2015/03/09 21:25:08, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/2136db0ac1af67ab3981249a2c15c2dee8e851d2
> Cr-Commit-Position: refs/heads/master@{#319735}

https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/dd-vkzRbbVc

Powered by Google App Engine
This is Rietveld 408576698