Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Unified Diff: net/spdy/spdy_priority_tree_test.cc

Issue 992613005: Revert of Test dead code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_headers_block_parser_test.cc ('k') | net/spdy/spdy_protocol.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_priority_tree_test.cc
diff --git a/net/spdy/spdy_priority_tree_test.cc b/net/spdy/spdy_priority_tree_test.cc
index e84d079aed0a2e077adcee5833056248ef16955f..fcfec6bff75c5ac2f3f1fef3e402ce189545c933 100644
--- a/net/spdy/spdy_priority_tree_test.cc
+++ b/net/spdy/spdy_priority_tree_test.cc
@@ -5,7 +5,6 @@
#include "net/spdy/spdy_priority_tree.h"
#include "base/basictypes.h"
-#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace net {
@@ -36,8 +35,6 @@
ASSERT_TRUE(tree.NodeExists(1));
EXPECT_EQ(100, tree.GetWeight(1));
EXPECT_FALSE(tree.NodeExists(5));
- EXPECT_THAT(tree.GetChildren(0),
- ::testing::Pointee(::testing::ElementsAre(1)));
EXPECT_TRUE(tree.AddNode(5, 0, 50, false));
// Should not be able to add a node with an id that already exists.
@@ -73,11 +70,6 @@
EXPECT_FALSE(tree.AddNode(7, 1, 70, false));
// Try adding a second child to node 13:
EXPECT_TRUE(tree.AddNode(17, 13, 170, false));
-
- // TODO(birenroy): Add a separate test that verifies weight invariants when
- // SetWeight is called.
- EXPECT_TRUE(tree.SetWeight(17, 150));
- EXPECT_EQ(150, tree.GetWeight(17));
ASSERT_TRUE(tree.ValidateInvariantsForTests());
}
« no previous file with comments | « net/spdy/spdy_headers_block_parser_test.cc ('k') | net/spdy/spdy_protocol.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698