Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 992503002: Locate test data more robustly (Closed)

Created:
5 years, 9 months ago by Mark Mentovai
Modified:
5 years, 9 months ago
Reviewers:
Robert Sesek, scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Locate test data more robustly. Test code that requires test data should call Paths::TestDataRoot() to obtain the test data root. This will use the CRASHPAD_TEST_DATA_ROOT environment variable if set. Otherwise, it will look for test data at known locations relative to the executable path. If the test data is not found in any of these locations, it falls back to using the working directory, the same as the current behavior. BUG=crashpad:4 TEST=crashpad_util_test Paths.TestDataRoot and others R=rsesek@chromium.org, scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/32a9d410ca0b22a17f5eade86057e6c4cdfa7f81

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Check marker_path #

Patch Set 4 : 2015 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -188 lines) Patch
M build/run_tests.py View 1 chunk +1 line, -4 lines 0 comments Download
M util/net/http_body_test.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M util/net/http_multipart_builder_test.cc View 4 chunks +17 lines, -18 lines 0 comments Download
M util/net/http_transport_test.cc View 3 chunks +7 lines, -4 lines 0 comments Download
D util/test/executable_path.h View 1 chunk +0 lines, -29 lines 0 comments Download
D util/test/executable_path_mac.cc View 1 chunk +0 lines, -37 lines 0 comments Download
D util/test/executable_path_test.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D util/test/executable_path_win.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M util/test/multiprocess_exec_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A util/test/paths.h View 1 2 3 1 chunk +49 lines, -0 lines 0 comments Download
A util/test/paths.cc View 1 2 1 chunk +101 lines, -0 lines 0 comments Download
A + util/test/paths_mac.cc View 2 chunks +3 lines, -2 lines 0 comments Download
A + util/test/paths_test.cc View 2 chunks +13 lines, -3 lines 0 comments Download
A + util/test/paths_test_data_root.txt View 2 chunks +3 lines, -6 lines 0 comments Download
A + util/test/paths_win.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M util/util.gyp View 3 chunks +5 lines, -4 lines 0 comments Download
M util/win/process_info_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Mark Mentovai
This is important for Chromium integration because it is not normal to have to run ...
5 years, 9 months ago (2015-03-08 21:34:58 UTC) #2
scottmg
lgtm https://codereview.chromium.org/992503002/diff/20001/util/test/paths.h File util/test/paths.h (right): https://codereview.chromium.org/992503002/diff/20001/util/test/paths.h#newcode1 util/test/paths.h:1: // Copyright 2014 The Crashpad Authors. All rights ...
5 years, 9 months ago (2015-03-09 17:18:11 UTC) #3
Mark Mentovai
https://codereview.chromium.org/992503002/diff/20001/util/test/paths.h File util/test/paths.h (right): https://codereview.chromium.org/992503002/diff/20001/util/test/paths.h#newcode1 util/test/paths.h:1: // Copyright 2014 The Crashpad Authors. All rights reserved. ...
5 years, 9 months ago (2015-03-09 17:24:15 UTC) #4
Robert Sesek
LGTM
5 years, 9 months ago (2015-03-09 18:51:44 UTC) #5
Mark Mentovai
5 years, 9 months ago (2015-03-09 19:13:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:50001) manually as
32a9d410ca0b22a17f5eade86057e6c4cdfa7f81 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698