Locate test data more robustly

util/net/http_transport_test.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #include "util/net/http_transport.h"
 
 #include <stdint.h>
 #include <stdlib.h>
 #include <string.h>
 
 #include <vector>
 
+#include "base/files/file_path.h"
 #include "base/format_macros.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/rand_util.h"
 #include "base/strings/stringprintf.h"
+#include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "gtest/gtest.h"
 #include "util/file/file_io.h"
 #include "util/net/http_body.h"
 #include "util/net/http_headers.h"
 #include "util/net/http_multipart_builder.h"
 #include "util/test/multiprocess_exec.h"
+#include "util/test/paths.h"
 
 namespace crashpad {
 namespace test {
 namespace {
 
 class HTTPTransportTestFixture : public MultiprocessExec {
  public:
   using RequestValidator =
       void(*)(HTTPTransportTestFixture*, const std::string&);
 
   HTTPTransportTestFixture(const HTTPHeaders& headers,
                            scoped_ptr<HTTPBodyStream> body_stream,
                            uint16_t http_response_code,
                            RequestValidator request_validator)
       : MultiprocessExec(),
         headers_(headers),
         body_stream_(body_stream.Pass()),
         response_code_(http_response_code),
         request_validator_(request_validator) {
-    // TODO(rsesek): Use a more robust mechanism to locate testdata
-    // <https://code.google.com/p/crashpad/issues/detail?id=4>.
+    base::FilePath server_path = Paths::TestDataRoot().Append(
+        FILE_PATH_LITERAL("util/net/http_transport_test_server.py"));
 #if defined(OS_POSIX)
-    SetChildCommand("util/net/http_transport_test_server.py", nullptr);
+    SetChildCommand(server_path.value(), nullptr);
 #elif defined(OS_WIN)
     // Explicitly invoke a shell and python so that python can be found in the
     // path, and run the test script.
     std::vector<std::string> args;
     args.push_back("/c");
     args.push_back("python");
-    args.push_back("util/net/http_transport_test_server.py");
+    args.push_back(base::UTF16ToUTF8(server_path.value()));
     SetChildCommand(getenv("COMSPEC"), &args);
 #endif  // OS_POSIX
   }
 
   const HTTPHeaders& headers() { return headers_; }
 
  private:
   void MultiprocessParent() override {
     // Use Logging*File() instead of Checked*File() so that the test can fail
     // gracefully with a gtest assertion if the child does not execute properly.
@@ skipping 196 matching lines @@
   headers[kContentLength] = base::StringPrintf("%" PRIuS, strlen(kTextBody));
 
   HTTPTransportTestFixture test(headers, body_stream.Pass(), 200,
       &UnchunkedPlainText);
   test.Run();
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad