Locate test data more robustly

util/net/http_multipart_builder_test.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #include "util/net/http_multipart_builder.h"
 
 #include <vector>
 
 #include "gtest/gtest.h"
 #include "util/net/http_body.h"
 #include "util/net/http_body_test_util.h"
+#include "util/test/paths.h"
 
 namespace crashpad {
 namespace test {
 namespace {
 
 std::vector<std::string> SplitCRLF(const std::string& string) {
   std::vector<std::string> lines;
   size_t last_line = 0;
   for (size_t i = 0; i < string.length(); ++i) {
     if (string[i] == '\r' && i+1 < string.length() && string[i+1] == '\n') {
@@ skipping 56 matching lines @@
   EXPECT_EQ("", *lines_it++);
   EXPECT_EQ(kValue2, *lines_it++);
 
   EXPECT_EQ(boundary + "--", *lines_it++);
 
   EXPECT_EQ(lines.end(), lines_it);
 }
 
 TEST(HTTPMultipartBuilder, ThreeFileAttachments) {
   HTTPMultipartBuilder builder;
-  // TODO(rsesek): Use a more robust mechanism to locate testdata
-  // <https://code.google.com/p/crashpad/issues/detail?id=4>.
+  base::FilePath ascii_http_body_path = Paths::TestDataRoot().Append(
+      FILE_PATH_LITERAL("util/net/testdata/ascii_http_body.txt"));
   builder.SetFileAttachment("first",
                             "minidump.dmp",
-                            base::FilePath(FILE_PATH_LITERAL(
-                                "util/net/testdata/ascii_http_body.txt")),
+                            ascii_http_body_path,
                             "");
   builder.SetFileAttachment("second",
                             "minidump.dmp",
-                            base::FilePath(FILE_PATH_LITERAL(
-                                "util/net/testdata/ascii_http_body.txt")),
+                            ascii_http_body_path,
                             "text/plain");
   builder.SetFileAttachment("\"third 50% silly\"",
                             "test%foo.txt",
-                            base::FilePath(FILE_PATH_LITERAL(
-                                "util/net/testdata/ascii_http_body.txt")),
+                            ascii_http_body_path,
                             "text/plain");
 
   const char kFileContents[] = "This is a test.\n";
 
   scoped_ptr<HTTPBodyStream> body(builder.GetBodyStream());
   ASSERT_TRUE(body.get());
   std::string contents = ReadStreamToString(body.get());
   auto lines = SplitCRLF(contents);
   ASSERT_EQ(16u, lines.size());
   auto lines_it = lines.begin();
@@ skipping 51 matching lines @@
   EXPECT_EQ("", *lines_it++);
   EXPECT_EQ("overwrite", *lines_it++);
   EXPECT_EQ(boundary + "--", *lines_it++);
   EXPECT_EQ(lines.end(), lines_it);
 }
 
 TEST(HTTPMultipartBuilder, OverwriteFileAttachment) {
   HTTPMultipartBuilder builder;
   const char kValue[] = "1 2 3 test";
   builder.SetFormData("a key", kValue);
-  // TODO(rsesek): Use a more robust mechanism to locate testdata
-  // <https://code.google.com/p/crashpad/issues/detail?id=4>.
+  base::FilePath testdata_path =
+      Paths::TestDataRoot().Append(FILE_PATH_LITERAL("util/net/testdata"));
   builder.SetFileAttachment("minidump",
                             "minidump.dmp",
-                            base::FilePath(FILE_PATH_LITERAL(
-                                "util/net/testdata/binary_http_body.dat")),
+                            testdata_path.Append(FILE_PATH_LITERAL(
+                                "binary_http_body.dat")),
                             "");
   builder.SetFileAttachment("minidump2",
                             "minidump.dmp",
-                            base::FilePath(FILE_PATH_LITERAL(
-                                "util/net/testdata/binary_http_body.dat")),
+                            testdata_path.Append(FILE_PATH_LITERAL(
+                                "binary_http_body.dat")),
                             "");
   builder.SetFileAttachment("minidump",
                             "minidump.dmp",
-                            base::FilePath(FILE_PATH_LITERAL(
-                                "util/net/testdata/ascii_http_body.txt")),
+                            testdata_path.Append(FILE_PATH_LITERAL(
+                                "ascii_http_body.txt")),
                             "text/plain");
   scoped_ptr<HTTPBodyStream> body(builder.GetBodyStream());
   ASSERT_TRUE(body.get());
   std::string contents = ReadStreamToString(body.get());
   auto lines = SplitCRLF(contents);
   ASSERT_EQ(15u, lines.size());
   auto lines_it = lines.begin();
 
   const std::string& boundary = *lines_it++;
   EXPECT_GE(boundary.length(), 1u);
@@ skipping 21 matching lines @@
 
   EXPECT_EQ(boundary + "--", *lines_it++);
 
   EXPECT_EQ(lines.end(), lines_it);
 }
 
 TEST(HTTPMultipartBuilder, SharedFormDataAndAttachmentKeyNamespace) {
   HTTPMultipartBuilder builder;
   const char kValue1[] = "11111";
   builder.SetFormData("one", kValue1);
+  base::FilePath ascii_http_body_path = Paths::TestDataRoot().Append(
+      FILE_PATH_LITERAL("util/net/testdata/ascii_http_body.txt"));
   builder.SetFileAttachment("minidump",
                             "minidump.dmp",
-                            base::FilePath(FILE_PATH_LITERAL(
-                                "util/net/testdata/ascii_http_body.txt")),
+                            ascii_http_body_path,
                             "");
   const char kValue2[] = "this is not a file";
   builder.SetFormData("minidump", kValue2);
 
   scoped_ptr<HTTPBodyStream> body(builder.GetBodyStream());
   ASSERT_TRUE(body.get());
   std::string contents = ReadStreamToString(body.get());
   auto lines = SplitCRLF(contents);
   auto lines_it = lines.begin();
 
@@ skipping 24 matching lines @@
   ASSERT_DEATH(builder.SetFileAttachment("", "", base::FilePath(), "<>"), "");
   // Invalid but safe:
   builder.SetFileAttachment("", "", base::FilePath(), "0/totally/-invalid.pdf");
   // Valid and safe:
   builder.SetFileAttachment("", "", base::FilePath(), "application/xml+xhtml");
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad