Use GrTextureDomain in GrBicubicEffect to perform non-bleeding HQ filter drawBitmap.

Use GrTextureDomain in GrBicubicEffect to perform non-bleeding HQ filter drawBitmap.

Committed: http://code.google.com/p/skia/source/detail?r=12687

[Stephen White, 2013-12-12 01:50:07]

LGTM. Comments are nits.

https://codereview.chromium.org/99203011/diff/50001/src/gpu/effects/GrBicubic...
File src/gpu/effects/GrBicubicEffect.cpp (left):

https://codereview.chromium.org/99203011/diff/50001/src/gpu/effects/GrBicubic...
src/gpu/effects/GrBicubicEffect.cpp:92: builder->fsCodeAppendf("\tvec4 s%d =
%s(%s, f.x, s0%d, s1%d, s2%d, s3%d);\n", y, cubicBlendName.c_str(), coeff, y, y,
y, y);
Hey, good point. These variables are only used in the outer loop. Good catch!

https://codereview.chromium.org/99203011/diff/50001/src/gpu/effects/GrBicubic...
File src/gpu/effects/GrBicubicEffect.h (right):

https://codereview.chromium.org/99203011/diff/50001/src/gpu/effects/GrBicubic...
src/gpu/effects/GrBicubicEffect.h:40: static GrEffectRef* Create(GrTexture* tex,
const SkScalar coefficients[16]) {
Maybe this variant of the factory function should take a texture domain too, and
default to no domain (and clamp mode) if not specified. (The comment above seems
to suggest it does this, but it doesn't.)

[robertphillips, 2013-12-12 13:30:50]

lgtm

[bsalomon, 2013-12-13 20:53:25]

I also now skip the optimizations to remove the texture domain based on the
texel->pixel mapping since they aren't correct for bicubic.

https://codereview.chromium.org/99203011/diff/50001/src/gpu/effects/GrBicubic...
File src/gpu/effects/GrBicubicEffect.h (right):

https://codereview.chromium.org/99203011/diff/50001/src/gpu/effects/GrBicubic...
src/gpu/effects/GrBicubicEffect.h:40: static GrEffectRef* Create(GrTexture* tex,
const SkScalar coefficients[16]) {
On 2013/12/12 01:50:07, Stephen White wrote:
> Maybe this variant of the factory function should take a texture domain too,
and
> default to no domain (and clamp mode) if not specified. (The comment above
seems
> to suggest it does this, but it doesn't.)

Done.

[commit-bot: I haz the power, 2013-12-13 20:53:44]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/99203011/90001

[commit-bot: I haz the power, 2013-12-13 21:18:39]

Retried try job too often on Build-Mac10.7-Clang-x86-Release-Trybot for step(s)
BuildBench, BuildGm, BuildTools
http://skiabot-master.pogerlabs.com:10117/buildstatus?builder=Build-Mac10.7-C...

[commit-bot: I haz the power, 2013-12-16 14:57:58]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/99203011/110001

[commit-bot: I haz the power, 2013-12-16 15:18:14]

Change committed as 12687