Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Issue 990183003: Added EventSender.setTouchPointRadius() for layoutTests (Closed)

Created:
5 years, 9 months ago by d.pikalov
Modified:
5 years, 9 months ago
Reviewers:
Rick Byers
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added EventSender.setTouchPointRadius() for layoutTests A link to the Blink patch (layoutTests) https://codereview.chromium.org/990193002/ BUG= Committed: https://crrev.com/97a6dbc41736e484f1b5ad544f68f8d34013179b Cr-Commit-Position: refs/heads/master@{#321167}

Patch Set 1 #

Patch Set 2 : Added param 'set_state_moved' to EventSender::setTouchPointRadius() #

Patch Set 3 : Added myself to AUTHORS. Impl. of AddTouchPoint temporary reverted #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/renderer/test_runner/event_sender.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/event_sender.cc View 1 2 5 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
d.pikalov
5 years, 9 months ago (2015-03-16 17:26:35 UTC) #2
Rick Byers
LGTM Please add links in the description to the related CLs (i.e. the test fix ...
5 years, 9 months ago (2015-03-16 18:40:05 UTC) #3
Rick Byers
On 2015/03/16 18:40:05, Rick Byers wrote: > LGTM > > Please add links in the ...
5 years, 9 months ago (2015-03-16 19:46:23 UTC) #4
d.pikalov
5 years, 9 months ago (2015-03-17 10:02:14 UTC) #5
d.pikalov
Removed unused code chunk (set radius_x/y in EventSender::AddTouchPoint)
5 years, 9 months ago (2015-03-17 16:44:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990183003/40001
5 years, 9 months ago (2015-03-18 13:16:36 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/50455)
5 years, 9 months ago (2015-03-18 13:22:31 UTC) #11
d.pikalov
On 2015/03/16 19:46:23, Rick Byers wrote: > On 2015/03/16 18:40:05, Rick Byers wrote: > > ...
5 years, 9 months ago (2015-03-18 15:03:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990183003/60001
5 years, 9 months ago (2015-03-18 16:15:02 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-18 18:06:54 UTC) #16
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/97a6dbc41736e484f1b5ad544f68f8d34013179b Cr-Commit-Position: refs/heads/master@{#321167}
5 years, 9 months ago (2015-03-18 18:08:02 UTC) #17
Fabrice (no longer in Chrome)
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1011383006/ by fdegans@chromium.org. ...
5 years, 9 months ago (2015-03-19 11:09:37 UTC) #18
d.pikalov
5 years, 9 months ago (2015-03-19 14:07:33 UTC) #21
Message was sent while issue was closed.
I updated the patch after revert, please review. I removed changes in
AddTouchPoint() to pass layout-tests. Once this patch landed, I'll update blink
part.

Powered by Google App Engine
This is Rietveld 408576698