Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 1011383006: Revert of Added EventSender.setTouchPointRadius() for layoutTests (Closed)

Created:
5 years, 9 months ago by Fabrice (no longer in Chrome)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Added EventSender.setTouchPointRadius() for layoutTests (patchset #4 id:60001 of https://codereview.chromium.org/990183003/) Reason for revert: Layout tests failures, see crbug/468704 Original issue's description: > Added EventSender.setTouchPointRadius() for layoutTests > > A link to the Blink patch (layoutTests) https://codereview.chromium.org/990193002/ > > BUG= > > Committed: https://crrev.com/97a6dbc41736e484f1b5ad544f68f8d34013179b > Cr-Commit-Position: refs/heads/master@{#321167} TBR=rbyers@chromium.org,d.pikalov@partner.samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=468704 Committed: https://crrev.com/74b2e3951529b722af6fff7c3105d559c40fd4e6 Cr-Commit-Position: refs/heads/master@{#321335}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -35 lines) Patch
M AUTHORS View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/renderer/test_runner/event_sender.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/shell/renderer/test_runner/event_sender.cc View 5 chunks +19 lines, -30 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Fabrice (no longer in Chrome)
Created Revert of Added EventSender.setTouchPointRadius() for layoutTests
5 years, 9 months ago (2015-03-19 11:09:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011383006/1
5 years, 9 months ago (2015-03-19 11:09:46 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-19 11:09:48 UTC) #4
Andrew Hayden (chromium.org)
On 2015/03/19 11:09:48, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
5 years, 9 months ago (2015-03-19 11:30:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011383006/1
5 years, 9 months ago (2015-03-19 11:32:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 11:35:20 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 11:36:04 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74b2e3951529b722af6fff7c3105d559c40fd4e6
Cr-Commit-Position: refs/heads/master@{#321335}

Powered by Google App Engine
This is Rietveld 408576698