Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
989533002:
PRESUBMIT.py, more helpful and stable error message for #include check. (Closed)
|
Created:
5 years, 9 months ago by marja Modified:
5 years, 9 months ago Reviewers:
jochen (gone - plz use gerrit) CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPRESUBMIT.py, more helpful and stable error message for #include check.
Most problems are because of wrong collation or not reading the style guide, so
pointing people to those.
BUG=
Committed: https://crrev.com/a017dc48049f5401d15f00cb20a741f803d719ad
Cr-Commit-Position: refs/heads/master@{#319660}
Patch Set 1 #
Total comments: 2
Patch Set 2 : https #Patch Set 3 : rebased #Messages
Total messages: 21 (10 generated)
marja@chromium.org changed reviewers: + jochen@chromium.org - thakis@chromium.org
jochen, ptal
lgtm with nit https://codereview.chromium.org/989533002/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/989533002/diff/1/PRESUBMIT.py#newcode66 PRESUBMIT.py:66: 'collation (LC_COLLATE=C) and check http://google-styleguide.googlecode.com' can we have an https URL plz?
t https://codereview.chromium.org/989533002/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/989533002/diff/1/PRESUBMIT.py#newcode66 PRESUBMIT.py:66: 'collation (LC_COLLATE=C) and check http://google-styleguide.googlecode.com' On 2015/03/06 17:11:04, jochen (traveling) wrote: > can we have an https URL plz? Done.
The CQ bit was checked by marja@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org Link to the patchset: https://codereview.chromium.org/989533002/#ps20001 (title: "https")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989533002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply the patch.
The CQ bit was unchecked by commit-bot@chromium.org
The CQ bit was checked by marja@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org Link to the patchset: https://codereview.chromium.org/989533002/#ps40001 (title: "rebased")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989533002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply the patch.
The CQ bit was unchecked by commit-bot@chromium.org
No idea why this failed to apply the patch when the tryjobs are green! Let's just try again.
The CQ bit was checked by marja@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989533002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/a017dc48049f5401d15f00cb20a741f803d719ad Cr-Commit-Position: refs/heads/master@{#319660} |
