| OLD | NEW |
| 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into depot_tools. | 8 for more details about the presubmit API built into depot_tools. |
| 9 """ | 9 """ |
| 10 | 10 |
| (...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 55 ) | 55 ) |
| 56 | 56 |
| 57 _TEST_ONLY_WARNING = ( | 57 _TEST_ONLY_WARNING = ( |
| 58 'You might be calling functions intended only for testing from\n' | 58 'You might be calling functions intended only for testing from\n' |
| 59 'production code. It is OK to ignore this warning if you know what\n' | 59 'production code. It is OK to ignore this warning if you know what\n' |
| 60 'you are doing, as the heuristics used to detect the situation are\n' | 60 'you are doing, as the heuristics used to detect the situation are\n' |
| 61 'not perfect. The commit queue will not block on this warning.') | 61 'not perfect. The commit queue will not block on this warning.') |
| 62 | 62 |
| 63 | 63 |
| 64 _INCLUDE_ORDER_WARNING = ( | 64 _INCLUDE_ORDER_WARNING = ( |
| 65 'Your #include order seems to be broken. Send mail to\n' | 65 'Your #include order seems to be broken. Remember to use the right ' |
| 66 'marja@chromium.org if this is not the case.') | 66 'collation (LC_COLLATE=C) and check https://google-styleguide.googlecode' |
| 67 | 67 '.com/svn/trunk/cppguide.html#Names_and_Order_of_Includes') |
| 68 | 68 |
| 69 _BANNED_OBJC_FUNCTIONS = ( | 69 _BANNED_OBJC_FUNCTIONS = ( |
| 70 ( | 70 ( |
| 71 'addTrackingRect:', | 71 'addTrackingRect:', |
| 72 ( | 72 ( |
| 73 'The use of -[NSView addTrackingRect:owner:userData:assumeInside:] is' | 73 'The use of -[NSView addTrackingRect:owner:userData:assumeInside:] is' |
| 74 'prohibited. Please use CrTrackingArea instead.', | 74 'prohibited. Please use CrTrackingArea instead.', |
| 75 'http://dev.chromium.org/developers/coding-style/cocoa-dos-and-donts', | 75 'http://dev.chromium.org/developers/coding-style/cocoa-dos-and-donts', |
| 76 ), | 76 ), |
| 77 False, | 77 False, |
| (...skipping 1680 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 1758 # Explicitly iterate over copies of dicts since we mutate them. | 1758 # Explicitly iterate over copies of dicts since we mutate them. |
| 1759 for master in builders.keys(): | 1759 for master in builders.keys(): |
| 1760 for builder in builders[master].keys(): | 1760 for builder in builders[master].keys(): |
| 1761 # Do not trigger presubmit builders, since they're likely to fail | 1761 # Do not trigger presubmit builders, since they're likely to fail |
| 1762 # (e.g. OWNERS checks before finished code review), and we're | 1762 # (e.g. OWNERS checks before finished code review), and we're |
| 1763 # running local presubmit anyway. | 1763 # running local presubmit anyway. |
| 1764 if 'presubmit' in builder: | 1764 if 'presubmit' in builder: |
| 1765 builders[master].pop(builder) | 1765 builders[master].pop(builder) |
| 1766 | 1766 |
| 1767 return builders | 1767 return builders |
| OLD | NEW |