PRESUBMIT.py, more helpful and stable error message for #include check.

PRESUBMIT.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for Chromium.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into depot_tools.
 """
 
@@ skipping 44 matching lines @@
 )
 
 _TEST_ONLY_WARNING = (
     'You might be calling functions intended only for testing from\n'
     'production code.  It is OK to ignore this warning if you know what\n'
     'you are doing, as the heuristics used to detect the situation are\n'
     'not perfect.  The commit queue will not block on this warning.')
 
 
 _INCLUDE_ORDER_WARNING = (
-    'Your #include order seems to be broken. Send mail to\n'
-    'marja@chromium.org if this is not the case.')
-
+    'Your #include order seems to be broken. Remember to use the right '
+    'collation (LC_COLLATE=C) and check http://google-styleguide.googlecode.com'

[jochen (gone - plz use gerrit), 2015/03/06 17:11:04]

can we have an https URL plz?

[marja, 2015/03/09 09:32:34]

Done.

+    '/svn/trunk/cppguide.html#Names_and_Order_of_Includes')
 
 _BANNED_OBJC_FUNCTIONS = (
     (
       'addTrackingRect:',
       (
        'The use of -[NSView addTrackingRect:owner:userData:assumeInside:] is'
        'prohibited. Please use CrTrackingArea instead.',
        'http://dev.chromium.org/developers/coding-style/cocoa-dos-and-donts',
       ),
       False,
@@ skipping 1679 matching lines @@
     # Explicitly iterate over copies of dicts since we mutate them.
     for master in builders.keys():
       for builder in builders[master].keys():
         # Do not trigger presubmit builders, since they're likely to fail
         # (e.g. OWNERS checks before finished code review), and we're
         # running local presubmit anyway.
         if 'presubmit' in builder:
           builders[master].pop(builder)
 
   return builders