Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 98893006: Make texture domain a helper so that it can be incorporated into other effects. (Closed)

Created:
7 years ago by bsalomon
Modified:
7 years ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Make texture domain a helper so that it can be incorporated into other effects. Committed: http://code.google.com/p/skia/source/detail?r=12569

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rename GrTextureDomainEffect.[h|cpp] to GrTextureDomain.[h|cpp] #

Unified diffs Side-by-side diffs Delta from patch set Stats (+350 lines, -412 lines) Patch
M gyp/gpu.gypi View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A src/gpu/effects/GrTextureDomain.h View 1 2 1 chunk +169 lines, -0 lines 0 comments Download
A + src/gpu/effects/GrTextureDomain.cpp View 1 2 7 chunks +150 lines, -91 lines 0 comments Download
M src/gpu/effects/GrTextureDomainEffect.h View 1 2 1 chunk +0 lines, -89 lines 0 comments Download
M src/gpu/effects/GrTextureDomainEffect.cpp View 1 2 1 chunk +0 lines, -221 lines 0 comments Download
M src/gpu/gl/GrGLEffect.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.h View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bsalomon
7 years ago (2013-12-04 21:27:32 UTC) #1
jvanverth1
LGTM. The only thing that bothers me is that GrTextureDomain is still being contained in ...
7 years ago (2013-12-04 21:42:53 UTC) #2
bsalomon
On 2013/12/04 21:42:53, JimVV wrote: > LGTM. The only thing that bothers me is that ...
7 years ago (2013-12-04 21:44:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/98893006/40001
7 years ago (2013-12-09 16:51:28 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-09 17:03:07 UTC) #5
Message was sent while issue was closed.
Change committed as 12569

Powered by Google App Engine
This is Rietveld 408576698